From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N0bCX-0007yG-9E for qemu-devel@nongnu.org; Wed, 21 Oct 2009 09:26:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N0bCR-0007p0-4T for qemu-devel@nongnu.org; Wed, 21 Oct 2009 09:26:03 -0400 Received: from [199.232.76.173] (port=55723 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N0bCQ-0007od-RT for qemu-devel@nongnu.org; Wed, 21 Oct 2009 09:25:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28263) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N0bCP-0007Q4-6F for qemu-devel@nongnu.org; Wed, 21 Oct 2009 09:25:57 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9LDPt3m007482 for ; Wed, 21 Oct 2009 09:25:55 -0400 From: Gerd Hoffmann Date: Wed, 21 Oct 2009 15:25:27 +0200 Message-Id: <1256131543-28416-7-git-send-email-kraxel@redhat.com> In-Reply-To: <1256131543-28416-1-git-send-email-kraxel@redhat.com> References: <1256131543-28416-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 06/22] ne2k_isa: use qdev properties for configuration. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann Signed-off-by: Gerd Hoffmann --- hw/ne2000-isa.c | 17 +++++++---------- hw/ne2000.c | 6 +++--- hw/ne2000.h | 2 +- 3 files changed, 11 insertions(+), 14 deletions(-) diff --git a/hw/ne2000-isa.c b/hw/ne2000-isa.c index e346731..1da0d54 100644 --- a/hw/ne2000-isa.c +++ b/hw/ne2000-isa.c @@ -38,13 +38,8 @@ typedef struct ISANE2000State { static void isa_ne2000_cleanup(VLANClientState *vc) { NE2000State *s = vc->opaque; - ISANE2000State *isa = container_of(s, ISANE2000State, ne2000); - unregister_savevm("ne2000", s); - - isa_unassign_ioport(isa->iobase, 16); - isa_unassign_ioport(isa->iobase + 0x10, 2); - isa_unassign_ioport(isa->iobase + 0x1f, 1); + s->vc = NULL; } static int isa_ne2000_initfn(ISADevice *dev) @@ -65,13 +60,14 @@ static int isa_ne2000_initfn(ISADevice *dev) isa_init_irq(dev, &s->irq, isa->isairq); - qdev_get_macaddr(&dev->qdev, s->macaddr); + qemu_macaddr_default_if_unset(&s->c.macaddr); ne2000_reset(s); - s->vc = qdev_get_vlan_client(&dev->qdev, + s->vc = qemu_new_vlan_client(s->c.vlan, s->c.peer, + dev->qdev.info->name, dev->qdev.id, ne2000_can_receive, ne2000_receive, NULL, isa_ne2000_cleanup, s); - qemu_format_nic_info_str(s->vc, s->macaddr); + qemu_format_nic_info_str(s->vc, s->c.macaddr.a); register_savevm("ne2000", -1, 2, ne2000_save, ne2000_load, s); return 0; @@ -84,9 +80,9 @@ void isa_ne2000_init(int base, int irq, NICInfo *nd) qemu_check_nic_model(nd, "ne2k_isa"); dev = isa_create("ne2k_isa"); - dev->qdev.nd = nd; /* hack alert */ qdev_prop_set_uint32(&dev->qdev, "iobase", base); qdev_prop_set_uint32(&dev->qdev, "irq", irq); + qdev_set_nic_properties(&dev->qdev, nd); qdev_init_nofail(&dev->qdev); } @@ -97,6 +93,7 @@ static ISADeviceInfo ne2000_isa_info = { .qdev.props = (Property[]) { DEFINE_PROP_HEX32("iobase", ISANE2000State, iobase, 0x300), DEFINE_PROP_UINT32("irq", ISANE2000State, isairq, 9), + DEFINE_NIC_PROPERTIES(ISANE2000State, ne2000.c), DEFINE_PROP_END_OF_LIST(), }, }; diff --git a/hw/ne2000.c b/hw/ne2000.c index 87f1e59..7ce56ff 100644 --- a/hw/ne2000.c +++ b/hw/ne2000.c @@ -126,7 +126,7 @@ void ne2000_reset(NE2000State *s) int i; s->isr = ENISR_RESET; - memcpy(s->mem, s->macaddr, 6); + memcpy(s->mem, &s->c.macaddr, 6); s->mem[14] = 0x57; s->mem[15] = 0x57; @@ -758,13 +758,13 @@ static int pci_ne2000_init(PCIDevice *pci_dev) PCI_ADDRESS_SPACE_IO, ne2000_map); s = &d->ne2000; s->irq = d->dev.irq[0]; - qdev_get_macaddr(&d->dev.qdev, s->macaddr); + qdev_get_macaddr(&d->dev.qdev, s->c.macaddr.a); ne2000_reset(s); s->vc = qdev_get_vlan_client(&d->dev.qdev, ne2000_can_receive, ne2000_receive, NULL, ne2000_cleanup, s); - qemu_format_nic_info_str(s->vc, s->macaddr); + qemu_format_nic_info_str(s->vc, s->c.macaddr.a); register_savevm("ne2000", -1, 3, pci_ne2000_save, pci_ne2000_load, d); return 0; diff --git a/hw/ne2000.h b/hw/ne2000.h index 92a2ddb..7842246 100644 --- a/hw/ne2000.h +++ b/hw/ne2000.h @@ -23,7 +23,7 @@ typedef struct NE2000State { uint8_t mult[8]; /* multicast mask array */ qemu_irq irq; VLANClientState *vc; - uint8_t macaddr[6]; + NICConf c; uint8_t mem[NE2000_MEM_SIZE]; } NE2000State; -- 1.6.2.5