qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: juha.riihimaki@nokia.com
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] target-arm: fix incorrect temporary variable freeing
Date: Mon, 26 Oct 2009 13:02:37 +0200	[thread overview]
Message-ID: <1256554957-2279-1-git-send-email-juha.riihimaki@nokia.com> (raw)

From: Juha Riihimäki <juha.riihimaki@nokia.com>

tmp4 and tmp5 temporary variables are allocated using tcg_const_i32
but incorrectly released using dead_tmp which will cause resource
leak tracking to report false leaks.

Signed-off-by: Juha Riihimäki <juha.riihimaki@nokia.com>
---
 target-arm/translate.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/target-arm/translate.c b/target-arm/translate.c
index 9d13d42..1988cc6 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -5535,8 +5535,8 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn)
                 }
                 tmp3 = neon_load_reg(rm, 1);
                 gen_helper_neon_tbl(tmp3, tmp3, tmp, tmp4, tmp5);
-                dead_tmp(tmp5);
-                dead_tmp(tmp4);
+                tcg_temp_free_i32(tmp5);
+                tcg_temp_free_i32(tmp4);
                 neon_store_reg(rd, 0, tmp2);
                 neon_store_reg(rd, 1, tmp3);
                 dead_tmp(tmp);
-- 
1.6.5

             reply	other threads:[~2009-10-26 11:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-26 11:02 juha.riihimaki [this message]
2009-10-26 11:21 ` [Qemu-devel] [PATCH] target-arm: fix incorrect temporary variable freeing Laurent Desnogues

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1256554957-2279-1-git-send-email-juha.riihimaki@nokia.com \
    --to=juha.riihimaki@nokia.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).