From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N2OGV-0004DO-E3 for qemu-devel@nongnu.org; Mon, 26 Oct 2009 08:01:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N2OGO-00047m-Ur for qemu-devel@nongnu.org; Mon, 26 Oct 2009 08:01:33 -0400 Received: from [199.232.76.173] (port=39346 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N2OGO-00047Q-M0 for qemu-devel@nongnu.org; Mon, 26 Oct 2009 08:01:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16498) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N2OGN-0000ff-C5 for qemu-devel@nongnu.org; Mon, 26 Oct 2009 08:01:28 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9QC1Qeh010784 for ; Mon, 26 Oct 2009 08:01:26 -0400 From: Amit Shah Date: Mon, 26 Oct 2009 17:30:37 +0530 Message-Id: <1256558437-24171-3-git-send-email-amit.shah@redhat.com> In-Reply-To: <1256558437-24171-2-git-send-email-amit.shah@redhat.com> References: <1256558437-24171-1-git-send-email-amit.shah@redhat.com> <1256558437-24171-2-git-send-email-amit.shah@redhat.com> Subject: [Qemu-devel] [PATCH v10 2/2] virtio-console: Add a new virtserialport device for generic serial port support List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Amit Shah This patch adds generic serial ports over the virtio serial bus. These ports have a few more options that are not relevant for virtio console ports: the ability to cache buffers that are received for a port while it's disconnected, setting of limits to the bytes that are cached so as to prevent OOM conditions, etc. Sample uses for such a device can be obtaining info from the guest like the file systems used, apps installed, etc. for offline usage and logged-in users, clipboard copy-paste, etc. for online usage. For requirements, use-cases, test cases and some history see http://www.linux-kvm.org/page/VMchannel_Requirements Signed-off-by: Amit Shah --- hw/virtio-console.c | 38 ++++++++++++++++++++++++++++++++++++++ 1 files changed, 38 insertions(+), 0 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index a14133b..c27e556 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console.c @@ -107,3 +107,41 @@ static void virtcon_register(void) virtio_serial_port_qdev_register(&virtcon_info); } device_init(virtcon_register) + + +/* Generic Virtio Serial Ports */ +static int virtserial_port_initfn(VirtIOSerialDevice *dev) +{ + VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev, &dev->qdev); + VirtConsole *vcon = DO_UPCAST(VirtConsole, port, port); + + port->info = dev->info; + + if (vcon->chr) { + qemu_chr_add_handlers(vcon->chr, chr_can_read, chr_read, chr_event, + vcon); + } + return 0; +} + +static VirtIOSerialPortInfo virtserial_port_info = { + .qdev.name = "virtserialport", + .qdev.size = sizeof(VirtConsole), + .init = virtserial_port_initfn, + .have_data = flush_buf, + .qdev.props = (Property[]) { + DEFINE_PROP_CHR("chardev", VirtConsole, chr), + DEFINE_PROP_STRING("name", VirtConsole, port.name), + DEFINE_PROP_INT32("cache_buffers", VirtConsole, port.cache_buffers, 1), + DEFINE_PROP_UINT64("byte_limit", VirtConsole, port.byte_limit, 0), + DEFINE_PROP_UINT64("guest_byte_limit", VirtConsole, + port.guest_byte_limit, 0), + DEFINE_PROP_END_OF_LIST(), + }, +}; + +static void virtserial_port_register(void) +{ + virtio_serial_port_qdev_register(&virtserial_port_info); +} +device_init(virtserial_port_register) -- 1.6.2.5