From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N34Ft-00006F-Bk
	for qemu-devel@nongnu.org; Wed, 28 Oct 2009 04:51:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N34Fo-00005e-Hj
	for qemu-devel@nongnu.org; Wed, 28 Oct 2009 04:51:44 -0400
Received: from [199.232.76.173] (port=33734 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N34Fo-00005W-DQ
	for qemu-devel@nongnu.org; Wed, 28 Oct 2009 04:51:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:27134)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1N34Fn-0003Dk-Pr
	for qemu-devel@nongnu.org; Wed, 28 Oct 2009 04:51:40 -0400
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <1256700810-sup-7579@xpc65.scottt>
References: <1256667399-3149-1-git-send-email-markmc@redhat.com>
	<1256700810-sup-7579@xpc65.scottt>
Content-Type: text/plain
Date: Wed, 28 Oct 2009 08:49:35 +0000
Message-Id: <1256719775.5105.23.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 0/5] Fix packet queueing to allow full tap
	queue drain
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Scott Tsai <scottt.tw@gmail.com>
Cc: Sven Rudolph <sven_rudolph@drewag.de>, qemu-devel <qemu-devel@nongnu.org>

On Wed, 2009-10-28 at 11:36 +0800, Scott Tsai wrote:
> >         Scott, Sven, if you could test the tap-drain-queue branch from
> > my tree, that would be great:
> >   http://repo.or.cz/w/qemu/markmc.git
> > 
> > Thanks,
> > Mark. 
> 
> Mark,
> I've tested http://repo.or.cz/w/qemu/markmc.git and it indeed works
> for my test case
> (NFS through emulated smc91c111 NIC on arm-integragorcp)

Many thanks for the report and confirming the fix

> How about adding a comment in tap_send() about when
> qemu_send_packet_async() would return 0 and -1?
> 
> I'd also recommend checking for the case of qemu_send_packet_async()
> returning -1 and dropping a packet and have a debug message guarded by
> #ifdef DEBUG_TAP in case the qemu_can_send_packet() check is ever
> removed in future modifications of the code.

Yeah, it's fairly gnarly code alright. I'd prefer to make it more
obvious with something like:

  ret = qemu_send_packet_async();
  switch (ret) {
  case NET_PACKET_AGAIN:
      tap_disable_write_poll();
      return;

  case NET_PACKET_DROP:
      /* drop! */
      return;
  }

Added to my TODO list

> Also, would it be possible to get the stable-0.11 version of the patch
> into the soon to be released Fedora 12? I've written some embedded
> Linux tutorials for Taiwanese consumer electronics developers that
> recommends using qemu on Fedora. Being able to rely on NFS always
> working in Fedora's qmeu packet would really help :)

Filed https://bugzilla.redhat.com/531419 ... I'll pull it in later
today.

qemu-system-arm on F12 works okay then? That's good to know, it's the
first I've heard of someone using it :-)

Thanks,
Mark.