qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Mark McLoughlin <markmc@redhat.com>
To: kirkland@canonical.com
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Scott Tsai <scottt.tw@gmail.com>,
	qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network
Date: Thu, 29 Oct 2009 15:01:18 +0000	[thread overview]
Message-ID: <1256828478.10825.79.camel@blaa> (raw)
In-Reply-To: <1256828478.25064.126.camel@x200>

On Thu, 2009-10-29 at 10:01 -0500, Dustin Kirkland wrote:
> On Thu, 2009-10-29 at 14:48 +0000, Mark McLoughlin wrote:
> > Ah, it all makes sense now.
> > 
> > I was getting confused between HOST_* and GUEST_*
> > 
> > this should have been:
> > 
> >     features |= (1 << VIRTIO_NET_F_MAC);
> >     features |= (1 << VIRTIO_NET_F_HOST_CSUM);
> >     features |= (1 << VIRTIO_NET_F_HOST_TSO4);
> >     features |= (1 << VIRTIO_NET_F_HOST_TSO6);
> >     features |= (1 << VIRTIO_NET_F_HOST_ECN);
> > 
> > Could you try that Dustin?
> 
> Hmm, not sure I'm doing this correctly...  I tried changing the
> following, but looks like I might also have to define these as well,
> since:
> 
> /tmp/qemu-kvm/qemu-kvm/hw/virtio-net.c:167: error:
> ‘VIRTIO_NET_F_HOST_CSUM’ undeclared (first use in this function)

Sorry, should be VIRTIO_NET_F_CSUM ... the rest is correct

Thanks,
mark.

  reply	other threads:[~2009-10-29 15:03 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-28 19:22 [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network Dustin Kirkland
2009-10-28 19:29 ` [Qemu-devel] " Dustin Kirkland
2009-10-29  3:12 ` [Qemu-devel] " Scott Tsai
2009-10-29  9:16 ` Mark McLoughlin
2009-10-29 12:00   ` Scott Tsai
2009-10-29 12:16     ` Mark McLoughlin
2009-10-29 12:21       ` Scott Tsai
2009-10-29 14:11       ` Anthony Liguori
2009-10-29 14:25         ` Mark McLoughlin
2009-10-29 14:34           ` Dustin Kirkland
2009-10-29 14:46             ` Dustin Kirkland
2009-10-29 14:50               ` Mark McLoughlin
2009-10-29 14:39           ` Anthony Liguori
2009-10-29 14:48             ` Mark McLoughlin
2009-10-29 15:01               ` Dustin Kirkland
2009-10-29 15:01                 ` Mark McLoughlin [this message]
2009-10-29 15:13                   ` Dustin Kirkland
2009-10-29 15:15                     ` Mark McLoughlin
2009-10-29 15:34               ` [Qemu-devel] [PATCH] whitelist host virtio networking features [was Re: qemu-kvm-0.11 regression, crashes on older ...] Dustin Kirkland
2009-10-30 21:15                 ` [Qemu-devel] " Dustin Kirkland
2009-11-02 14:38                   ` Mark McLoughlin
2009-11-02 15:42                     ` Anthony Liguori
2009-11-02 15:52                       ` Jamie Lokier
2009-11-02 18:20                         ` Michael Tokarev
2009-11-02 19:39                           ` Jamie Lokier
2009-11-02 18:55                         ` Anthony Liguori
2009-11-02 19:25                           ` Dustin Kirkland
2009-11-02 20:50                             ` Anthony Liguori
2009-11-05  5:06                               ` Jamie Lokier
2009-11-02 16:58                     ` Dustin Kirkland
2009-10-29 14:39     ` [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network Dustin Kirkland
2009-10-29 23:22       ` Scott Tsai
2009-10-29 12:23   ` [Qemu-devel] " Michael S. Tsirkin
2009-10-29 14:38     ` Avi Kivity
2009-10-29 15:03       ` Michael S. Tsirkin
2009-10-29 14:43   ` [Qemu-devel] " Dustin Kirkland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1256828478.10825.79.camel@blaa \
    --to=markmc@redhat.com \
    --cc=kirkland@canonical.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rusty@rustcorp.com.au \
    --cc=scottt.tw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).