From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N3WXH-0000Vy-Ub
	for qemu-devel@nongnu.org; Thu, 29 Oct 2009 11:03:36 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N3WXD-0000Sy-6q
	for qemu-devel@nongnu.org; Thu, 29 Oct 2009 11:03:35 -0400
Received: from [199.232.76.173] (port=56897 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N3WXC-0000Sm-PS
	for qemu-devel@nongnu.org; Thu, 29 Oct 2009 11:03:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55799)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1N3WXA-0003Fk-UM
	for qemu-devel@nongnu.org; Thu, 29 Oct 2009 11:03:29 -0400
Subject: Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests
	with virtio network
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <1256828478.25064.126.camel@x200>
References: <d9c105ea0910281222u76a61a2by3cc924e85d40a865@mail.gmail.com>
	<1256807803.10825.39.camel@blaa>  <1256815818-sup-7805@xpc65.scottt>
	<1256818566.10825.58.camel@blaa>  <4AE9A299.5060003@codemonkey.ws>
	<1256826351.10825.69.camel@blaa>  <4AE9A90F.1060108@codemonkey.ws>
	<1256827719.10825.75.camel@blaa>  <1256828478.25064.126.camel@x200>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 29 Oct 2009 15:01:18 +0000
Message-Id: <1256828478.10825.79.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: kirkland@canonical.com
Cc: Rusty Russell <rusty@rustcorp.com.au>, Scott Tsai <scottt.tw@gmail.com>, qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>

On Thu, 2009-10-29 at 10:01 -0500, Dustin Kirkland wrote:
> On Thu, 2009-10-29 at 14:48 +0000, Mark McLoughlin wrote:
> > Ah, it all makes sense now.
> >=20
> > I was getting confused between HOST_* and GUEST_*
> >=20
> > this should have been:
> >=20
> >     features |=3D (1 << VIRTIO_NET_F_MAC);
> >     features |=3D (1 << VIRTIO_NET_F_HOST_CSUM);
> >     features |=3D (1 << VIRTIO_NET_F_HOST_TSO4);
> >     features |=3D (1 << VIRTIO_NET_F_HOST_TSO6);
> >     features |=3D (1 << VIRTIO_NET_F_HOST_ECN);
> >=20
> > Could you try that Dustin?
>=20
> Hmm, not sure I'm doing this correctly...  I tried changing the
> following, but looks like I might also have to define these as well,
> since:
>=20
> /tmp/qemu-kvm/qemu-kvm/hw/virtio-net.c:167: error:
> =E2=80=98VIRTIO_NET_F_HOST_CSUM=E2=80=99 undeclared (first use in this =
function)

Sorry, should be VIRTIO_NET_F_CSUM ... the rest is correct

Thanks,
mark.