From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N3uSb-0004ob-Fh
	for qemu-devel@nongnu.org; Fri, 30 Oct 2009 12:36:21 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N3uSW-0004lt-EA
	for qemu-devel@nongnu.org; Fri, 30 Oct 2009 12:36:20 -0400
Received: from [199.232.76.173] (port=55264 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N3uSV-0004lm-9p
	for qemu-devel@nongnu.org; Fri, 30 Oct 2009 12:36:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:29292)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1N3uSU-0007Fs-T6
	for qemu-devel@nongnu.org; Fri, 30 Oct 2009 12:36:15 -0400
Subject: Re: [Qemu-devel] [PATCH 5/5] tap: drain queue in tap_send()
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <4AEB1294.6000204@codemonkey.ws>
References: <1256667399-3149-1-git-send-email-markmc@redhat.com>
	<1256667399-3149-6-git-send-email-markmc@redhat.com>
	<4AEB1294.6000204@codemonkey.ws>
Content-Type: text/plain
Date: Fri, 30 Oct 2009 16:34:04 +0000
Message-Id: <1256920444.6899.145.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Scott Tsai <scottt.tw@gmail.com>, Sven Rudolph <Sven_Rudolph@drewag.de>, qemu-devel@nongnu.org

On Fri, 2009-10-30 at 11:21 -0500, Anthony Liguori wrote:
> Mark McLoughlin wrote:
> > Okay, let's try re-enabling the drain-entire-queue behaviour, with a
> > difference - before each subsequent packet, use qemu_can_send_packet()
> > to check that we can send it. This is similar to how we check before
> > polling the tap fd and avoids having to drop a packet if the receiver
> > cannot handle it.
> >
> > This patch should be a performance improvement since we no longer have
> > to go through the mainloop for each packet.
> >
> > Signed-off-by: Mark McLoughlin <markmc@redhat.com>
> >   
> 
> Could you rebase and rend this patch against master?  I've got 1-4 in 
> staging.
> 
> The GSO changes make resolving this non trivial (for me at least :-)).

Um, you've lost me :-)

You've got it in staging AFAICS, and anyway ... 5/5 is mostly a revert
of 1/5, so if 1/5 applied so should 5/5

What's in staging looks fine to me, except it doesn't build because of
problems with other patches

Thanks,
Mark.