qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <weil@mail.berlios.de>
To: QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH] Makefile: Fix problems in parallel builds
Date: Mon,  2 Nov 2009 19:21:48 +0100	[thread overview]
Message-ID: <1257186108-23012-1-git-send-email-weil@mail.berlios.de> (raw)
In-Reply-To: <1256841601-4964-1-git-send-email-uril@redhat.com>

The build-all rule used to call make recursively to
avoid problems with a wrong build order in parallel makes
(config-host.h was sometimes built too late).

Most object files depend on config-host.h, so adding
the missing prerequisites now allows to avoid
recursive calls of make and to simplify the rule for
build-all.

A similar patch from Uri Lublin which fixed the
rule for qemu-img.o is no longer needed.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 Makefile |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index c78d9ea..ae3532f 100644
--- a/Makefile
+++ b/Makefile
@@ -40,8 +40,7 @@ config-all-devices.mak: $(SUBDIR_DEVICES_MAK)
 
 -include config-all-devices.mak
 
-build-all: config-host.h config-all-devices.h $(DOCS) $(TOOLS)
-	$(call quiet-command, $(MAKE) $(SUBDIR_MAKEFLAGS) recurse-all,)
+build-all: $(DOCS) $(TOOLS) recurse-all
 
 config-host.h: config-host.h-timestamp
 config-host.h-timestamp: config-host.mak
@@ -207,9 +206,12 @@ bt-host.o: QEMU_CFLAGS += $(BLUEZ_CFLAGS)
 
 libqemu_common.a: $(obj-y)
 
+$(obj-y): config-host.h
+
 ######################################################################
 
 qemu-img.o: qemu-img-cmds.h
+qemu-img.o qemu-nbd.o qemu-io.o: config-host.h
 
 qemu-img$(EXESUF): qemu-img.o qemu-tool.o $(block-obj-y)
 
-- 
1.5.6.5

      reply	other threads:[~2009-11-02 18:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-29 18:40 [Qemu-devel] [PATCH] Makefile: make qemu-img dependant on config-host.h Uri Lublin
2009-11-02 18:21 ` Stefan Weil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1257186108-23012-1-git-send-email-weil@mail.berlios.de \
    --to=weil@mail.berlios.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).