From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N5m5i-0007dc-Pe for qemu-devel@nongnu.org; Wed, 04 Nov 2009 15:04:26 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N5m5e-0007am-Tn for qemu-devel@nongnu.org; Wed, 04 Nov 2009 15:04:26 -0500 Received: from [199.232.76.173] (port=58161 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N5m5e-0007af-LP for qemu-devel@nongnu.org; Wed, 04 Nov 2009 15:04:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:16286) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N5m5d-0006y7-Ug for qemu-devel@nongnu.org; Wed, 04 Nov 2009 15:04:22 -0500 From: Luiz Capitulino Date: Wed, 4 Nov 2009 18:03:59 -0200 Message-Id: <1257365047-25895-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [RFC 0/8]: QError v2 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, aliguori@us.ibm.com, kraxel@redhat.com, hollisb@us.ibm.com Hi, I can't remember seeing updated versions of a RFC series, but this should prevent Anthony's scripts from merging these patches. This new QError version has two major changes: the static error table has been dropped and I'm using symbolic names instead of error codes. Now, a call to: monitor_printf(mon, "husb: host usb device %d.%d is already open\n", bus_num, addr); Would become something like: qemu_error_new('DeviceAlreadyOpen', "{ 'bus_num': %d, 'addr': %d }", bus_num, addr); Which is basically what Anthony and other people were asking for, the only difference is that I'm not passing the symbolic name through the dictionary. The reason is that I have the impression it's less general (as it becomes mandatory to have a dict) and slightly more complicaded. The symbolic name can be freely defined, but we can have the common ones in qerror.h. Hopefully this version addresses the most important issues. Luiz.