From: Adam Litke <agl@us.ibm.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
agl@linux.vnet.ibm.com, qemu-devel@nongnu.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver
Date: Wed, 11 Nov 2009 09:08:34 -0600 [thread overview]
Message-ID: <1257952114.2876.29.camel@aglitke> (raw)
In-Reply-To: <200911111313.24226.rusty@rustcorp.com.au>
On Wed, 2009-11-11 at 13:13 +1030, Rusty Russell wrote:
> > It's not laziness, it's consistency. How is actual different than free
> > memory or any other stat?
>
> Because it's a COLLECTION of stats. For example, swap in should be < swap
> out. Now, the current Linux implementation of all_vm_events() is non-atomic
> anyway, so maybe we can just document this as best-effort. I'm saying that
> if it *is* a problem, I think we need a vq.
I can't see why we would care about the atomicity of the collection of
statistics. Best-effort is good enough. Any variance within the stats
will be overshadowed by the latency of the host-side management daemon.
> But it raises the question: what stats are generally useful cross-OS? Should
> we be supplying numbers like "unused" (free) "instantly discardable" (ie.
> clean), "discardable to disk" (ie. file-backed), "discardable to swap"
> (ie. swap-backed) and "unswappable" instead?
While I see the virtue in presenting abstracted memory stats that seem
more digestible in a virtualization context, I think we should keep the
raw stats. This concentrates the complexity in the host-side management
daemon, and allows the host daemon to make better decisions (ie. by
reacting to trends in individual statistics). Different OSes (or
different versions of the same OS), may also have different sets of
statistics that will provide the answers that a management daemon needs.
--
Thanks,
Adam
next prev parent reply other threads:[~2009-11-11 15:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 16:07 [Qemu-devel] [RFC] virtio: Report new guest memory statistics pertinent to memory ballooning (V2) Adam Litke
2009-11-09 16:32 ` [Qemu-devel] virtio: Add memory statistics reporting to the balloon driver Adam Litke
2009-11-10 2:42 ` [Qemu-devel] " Rusty Russell
2009-11-10 14:36 ` Anthony Liguori
2009-11-10 14:43 ` Avi Kivity
2009-11-10 14:58 ` Anthony Liguori
2009-11-11 9:24 ` Jamie Lokier
2009-11-11 10:12 ` Daniel P. Berrange
2009-11-11 13:26 ` Adam Litke
2009-11-11 15:00 ` Avi Kivity
2009-11-10 23:59 ` Rusty Russell
2009-11-10 21:52 ` Anthony Liguori
2009-11-11 0:02 ` Rusty Russell
2009-11-11 0:07 ` Anthony Liguori
2009-11-11 2:43 ` Rusty Russell
2009-11-11 15:08 ` Adam Litke [this message]
2009-11-12 2:29 ` Rusty Russell
2009-11-09 19:00 ` [Qemu-devel] [RFC] virtio: Report new guest memory statistics pertinent to memory ballooning (V2) Jamie Lokier
2009-11-09 19:16 ` Adam Litke
2009-11-09 21:15 ` Anthony Liguori
2009-11-10 13:23 ` Jamie Lokier
2009-11-09 19:01 ` Jamie Lokier
2009-11-09 19:23 ` Adam Litke
-- strict thread matches above, loose matches on Subject: below --
2009-11-05 22:50 [Qemu-devel] [RFC] virtio: Report new guest memory statistics pertinent to memory ballooning Adam Litke
2009-11-05 23:02 ` [Qemu-devel] virtio: Add memory statistics reporting to the balloon driver Adam Litke
2009-11-05 23:39 ` [Qemu-devel] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257952114.2876.29.camel@aglitke \
--to=agl@us.ibm.com \
--cc=agl@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).