From: Mark McLoughlin <markmc@redhat.com>
To: qemu-devel@nongnu.org
Cc: kraxel@redhat.com, quintela@redhat.com
Subject: [Qemu-devel] [RFC PATCH 0/7] Fix qemu_announce_self() properly
Date: Thu, 12 Nov 2009 20:28:55 +0000 [thread overview]
Message-ID: <1258057742-18699-1-git-send-email-markmc@redhat.com> (raw)
Hi,
The recent "fix" to qemu_announce_self() will segfault if you use
-netdev. The real root cause of the regression was the removal of the
assignment to NICInfo::vc that used to live in qdev_get_vlan_client().
Now that NICs are qdev-ified, we should just iterate over the
qdev tree to find NICs and send out the announce packet from each.
This series does just that. I've only lightly tested it, more
testing and comments welcome.
Pushed to the fix-announce-self-rfc branch at:
git://repo.or.cz/qemu/markmc.git
Cheers,
Mark.
next reply other threads:[~2009-11-12 20:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 20:28 Mark McLoughlin [this message]
2009-11-12 20:28 ` [Qemu-devel] [PATCH 1/7] net: remove NICInfo::vc Mark McLoughlin
2009-11-12 20:28 ` [Qemu-devel] [PATCH 2/7] qdev: add "net-client" property Mark McLoughlin
2009-11-16 9:03 ` [Qemu-devel] " Gerd Hoffmann
2009-11-12 20:28 ` [Qemu-devel] [PATCH 3/7] net: create the VLANClientState for NICs early Mark McLoughlin
2009-11-16 9:26 ` [Qemu-devel] " Gerd Hoffmann
2009-11-12 20:28 ` [Qemu-devel] [PATCH 4/7] net: kill off NICInfo/NICConf::vlan/netdev Mark McLoughlin
2009-11-12 20:29 ` [Qemu-devel] [PATCH 5/7] qdev: add qdev_foreach() Mark McLoughlin
2009-11-16 9:28 ` [Qemu-devel] " Gerd Hoffmann
2009-11-20 14:20 ` Mark McLoughlin
2009-11-23 9:55 ` Gerd Hoffmann
2009-11-12 20:29 ` [Qemu-devel] [PATCH 6/7] qdev: add qdev_prop_get_{macaddr, net_client}() Mark McLoughlin
2009-11-12 20:29 ` [Qemu-devel] [PATCH 7/7] net: fix qemu_announce_self() Mark McLoughlin
2009-11-13 7:41 ` Mark McLoughlin
2009-11-13 8:14 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258057742-18699-1-git-send-email-markmc@redhat.com \
--to=markmc@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).