From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N8gKU-0003FU-MK
	for qemu-devel@nongnu.org; Thu, 12 Nov 2009 15:31:42 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N8gKO-0003C8-T1
	for qemu-devel@nongnu.org; Thu, 12 Nov 2009 15:31:41 -0500
Received: from [199.232.76.173] (port=58765 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N8gKN-0003BM-UP
	for qemu-devel@nongnu.org; Thu, 12 Nov 2009 15:31:36 -0500
Received: from mx1.redhat.com ([209.132.183.28]:27034)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1N8gKM-0005AU-PC
	for qemu-devel@nongnu.org; Thu, 12 Nov 2009 15:31:35 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nACKVXeO028100
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 12 Nov 2009 15:31:33 -0500
From: Mark McLoughlin <markmc@redhat.com>
Date: Thu, 12 Nov 2009 20:28:55 +0000
Message-Id: <1258057742-18699-1-git-send-email-markmc@redhat.com>
Subject: [Qemu-devel] [RFC PATCH 0/7] Fix qemu_announce_self() properly
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: kraxel@redhat.com, quintela@redhat.com


Hi,
        The recent "fix" to qemu_announce_self() will segfault if you use
-netdev. The real root cause of the regression was the removal of the
assignment to NICInfo::vc that used to live in qdev_get_vlan_client().

        Now that NICs are qdev-ified, we should just iterate over the
qdev tree to find NICs and send out the announce packet from each.

        This series does just that. I've only lightly tested it, more
testing and comments welcome.

        Pushed to the fix-announce-self-rfc branch at:

  git://repo.or.cz/qemu/markmc.git

Cheers,
Mark.