qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, kraxel@redhat.com, armbru@redhat.com
Subject: [Qemu-devel] [PATCH 13/13] monitor: do_info_balloon(): Use QError
Date: Wed, 18 Nov 2009 23:05:36 -0200	[thread overview]
Message-ID: <1258592736-10252-14-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1258592736-10252-1-git-send-email-lcapitulino@redhat.com>

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 monitor.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/monitor.c b/monitor.c
index da05bf4..549e98b 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1722,10 +1722,9 @@ static void do_info_balloon(Monitor *mon, QObject **ret_data)
 
     actual = qemu_balloon_status();
     if (kvm_enabled() && !kvm_has_sync_mmu())
-        monitor_printf(mon, "Using KVM without synchronous MMU, "
-                       "ballooning disabled\n");
+        qemu_error_new(QERR_KVM_MISSING_CAP, "synchronous MMU", "balloon");
     else if (actual == 0)
-        monitor_printf(mon, "Ballooning not activated in VM\n");
+        qemu_error_new(QERR_DEVICE_NOT_ACTIVE, "balloon");
     else
         *ret_data = QOBJECT(qint_from_int((int)(actual >> 20)));
 }
-- 
1.6.5.3.148.g785c5

  parent reply	other threads:[~2009-11-19  1:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-19  1:05 [Qemu-devel] [PATCH 00/13]: QError v5 Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 01/13] QJSON: Introduce qobject_from_jsonv() Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 02/13] QString: Introduce qstring_append_chr() Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 03/13] QString: Introduce qstring_append_int() Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 04/13] QString: Introduce qstring_from_substr() Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 05/13] utests: Add qstring_append_chr() unit-test Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 06/13] utests: Add qstring_from_substr() unit-test Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 07/13] Introduce QError Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 08/13] monitor: QError support Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 09/13] QError: Add QERR_DEVICE_NOT_FOUND Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 10/13] qdev: Use QError for 'device not found' error Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 11/13] QError: Add QERR_DEVICE_NOT_ACTIVE Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 12/13] QError: Add QERR_KVM_MISSING_CAP Luiz Capitulino
2009-11-19  1:05 ` Luiz Capitulino [this message]
2009-11-19 13:59 ` [Qemu-devel] [PATCH 00/13]: QError v5 Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258592736-10252-14-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).