qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, kraxel@redhat.com, armbru@redhat.com
Subject: [Qemu-devel] [PATCH 01/13] QJSON: Introduce qobject_from_jsonv()
Date: Wed, 18 Nov 2009 23:05:24 -0200	[thread overview]
Message-ID: <1258592736-10252-2-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1258592736-10252-1-git-send-email-lcapitulino@redhat.com>

It accepts a va_list and will be used by QError. Also simplifies
the code a little, as the other qobject_from_() functions can
use it.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 qjson.c |   21 +++++++++++----------
 qjson.h |    2 ++
 2 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/qjson.c b/qjson.c
index 7270909..12e6cf0 100644
--- a/qjson.c
+++ b/qjson.c
@@ -34,10 +34,12 @@ static void parse_json(JSONMessageParser *parser, QList *tokens)
     s->result = json_parser_parse(tokens, s->ap);
 }
 
-QObject *qobject_from_json(const char *string)
+QObject *qobject_from_jsonv(const char *string, va_list *ap)
 {
     JSONParsingState state = {};
 
+    state.ap = ap;
+
     json_message_parser_init(&state.parser, parse_json);
     json_message_parser_feed(&state.parser, string, strlen(string));
     json_message_parser_flush(&state.parser);
@@ -46,22 +48,21 @@ QObject *qobject_from_json(const char *string)
     return state.result;
 }
 
+QObject *qobject_from_json(const char *string)
+{
+    return qobject_from_jsonv(string, NULL);
+}
+
 QObject *qobject_from_jsonf(const char *string, ...)
 {
-    JSONParsingState state = {};
+    QObject *obj;
     va_list ap;
 
     va_start(ap, string);
-    state.ap = &ap;
-
-    json_message_parser_init(&state.parser, parse_json);
-    json_message_parser_feed(&state.parser, string, strlen(string));
-    json_message_parser_flush(&state.parser);
-    json_message_parser_destroy(&state.parser);
-
+    obj = qobject_from_jsonv(string, &ap);
     va_end(ap);
 
-    return state.result;
+    return obj;
 }
 
 typedef struct ToJsonIterState
diff --git a/qjson.h b/qjson.h
index 7fce742..7afec2e 100644
--- a/qjson.h
+++ b/qjson.h
@@ -14,12 +14,14 @@
 #ifndef QJSON_H
 #define QJSON_H
 
+#include <stdarg.h>
 #include "qobject.h"
 #include "qstring.h"
 
 QObject *qobject_from_json(const char *string);
 QObject *qobject_from_jsonf(const char *string, ...)
     __attribute__((__format__ (__printf__, 1, 2)));
+QObject *qobject_from_jsonv(const char *string, va_list *ap);
 
 QString *qobject_to_json(const QObject *obj);
 
-- 
1.6.5.3.148.g785c5

  reply	other threads:[~2009-11-19  1:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-19  1:05 [Qemu-devel] [PATCH 00/13]: QError v5 Luiz Capitulino
2009-11-19  1:05 ` Luiz Capitulino [this message]
2009-11-19  1:05 ` [Qemu-devel] [PATCH 02/13] QString: Introduce qstring_append_chr() Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 03/13] QString: Introduce qstring_append_int() Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 04/13] QString: Introduce qstring_from_substr() Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 05/13] utests: Add qstring_append_chr() unit-test Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 06/13] utests: Add qstring_from_substr() unit-test Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 07/13] Introduce QError Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 08/13] monitor: QError support Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 09/13] QError: Add QERR_DEVICE_NOT_FOUND Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 10/13] qdev: Use QError for 'device not found' error Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 11/13] QError: Add QERR_DEVICE_NOT_ACTIVE Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 12/13] QError: Add QERR_KVM_MISSING_CAP Luiz Capitulino
2009-11-19  1:05 ` [Qemu-devel] [PATCH 13/13] monitor: do_info_balloon(): Use QError Luiz Capitulino
2009-11-19 13:59 ` [Qemu-devel] [PATCH 00/13]: QError v5 Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258592736-10252-2-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).