From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NB9PU-00071e-KT for qemu-devel@nongnu.org; Thu, 19 Nov 2009 10:59:04 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NB9PQ-0006wz-Vk for qemu-devel@nongnu.org; Thu, 19 Nov 2009 10:59:04 -0500 Received: from [199.232.76.173] (port=45305 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NB9PQ-0006wo-L8 for qemu-devel@nongnu.org; Thu, 19 Nov 2009 10:59:00 -0500 Received: from e2.ny.us.ibm.com ([32.97.182.142]:45348) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NB9PQ-0002C2-77 for qemu-devel@nongnu.org; Thu, 19 Nov 2009 10:59:00 -0500 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by e2.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id nAJFowiQ006183 for ; Thu, 19 Nov 2009 10:50:58 -0500 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id nAJFwwNO110916 for ; Thu, 19 Nov 2009 10:58:58 -0500 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id nAJFws1U012596 for ; Thu, 19 Nov 2009 08:58:55 -0700 From: Adam Litke In-Reply-To: <4B0562A0.7040507@redhat.com> References: <1258643169.3464.3.camel@aglitke> <1258643945.3464.5.camel@aglitke> <4B0562A0.7040507@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Thu, 19 Nov 2009 09:58:51 -0600 Message-ID: <1258646331.3464.18.camel@aglitke> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V3) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: linux-kernel@vger.kernel.org, Anthony Liguori , Rusty Russell , qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org On Thu, 2009-11-19 at 17:22 +0200, Avi Kivity wrote: > On 11/19/2009 05:19 PM, Adam Litke wrote: > > Rusty and Anthony, > > If I've addressed all outstanding issues, please consider this patch for > > inclusion. Thanks. > > > > +struct virtio_balloon_stat > > +{ > > + __le16 tag; > > + __le64 val; > > +}; > > + > > > > You're not doing endian conversion in the host? No. I was following by example. For the virtio_balloon, the existing code is careful so that the guest always writes data in little endian. -- Thanks, Adam