From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NB9t6-0000lt-VA for qemu-devel@nongnu.org; Thu, 19 Nov 2009 11:29:40 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NB9t2-0000jC-Du for qemu-devel@nongnu.org; Thu, 19 Nov 2009 11:29:40 -0500 Received: from [199.232.76.173] (port=53574 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NB9t1-0000j2-WF for qemu-devel@nongnu.org; Thu, 19 Nov 2009 11:29:36 -0500 Received: from e37.co.us.ibm.com ([32.97.110.158]:41142) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NB9t1-00087N-Jn for qemu-devel@nongnu.org; Thu, 19 Nov 2009 11:29:35 -0500 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e37.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id nAJGSKsR029050 for ; Thu, 19 Nov 2009 09:28:20 -0700 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id nAJGTGoE191102 for ; Thu, 19 Nov 2009 09:29:21 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id nAJ9MTXV016023 for ; Thu, 19 Nov 2009 02:22:30 -0700 From: Adam Litke In-Reply-To: <4B056EB8.9020509@redhat.com> References: <1258643169.3464.3.camel@aglitke> <1258643945.3464.5.camel@aglitke> <4B0562A0.7040507@redhat.com> <1258646331.3464.18.camel@aglitke> <4B056EB8.9020509@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Thu, 19 Nov 2009 10:29:09 -0600 Message-ID: <1258648149.3464.23.camel@aglitke> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V3) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: linux-kernel@vger.kernel.org, Anthony Liguori , Rusty Russell , qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org On Thu, 2009-11-19 at 18:13 +0200, Avi Kivity wrote: > On 11/19/2009 05:58 PM, Adam Litke wrote: > > On Thu, 2009-11-19 at 17:22 +0200, Avi Kivity wrote: > > > >> On 11/19/2009 05:19 PM, Adam Litke wrote: > >> > >>> Rusty and Anthony, > >>> If I've addressed all outstanding issues, please consider this patch for > >>> inclusion. Thanks. > >>> > >>> +struct virtio_balloon_stat > >>> +{ > >>> + __le16 tag; > >>> + __le64 val; > >>> +}; > >>> + > >>> > >>> > >> You're not doing endian conversion in the host? > >> > > No. I was following by example. For the virtio_balloon, the existing > > code is careful so that the guest always writes data in little endian. > > > > I don't follow. If the guest is careful to write little-endian, surely > the host must be equally careful to read little-endian? That is true and, by my reading of the existing qemu virtio-balloon device code, isn't virtio_balloon_set_config() on a big endian host already broken? -- Thanks, Adam