From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NBCY1-0007hJ-33 for qemu-devel@nongnu.org; Thu, 19 Nov 2009 14:20:05 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NBCXw-0007ec-8i for qemu-devel@nongnu.org; Thu, 19 Nov 2009 14:20:04 -0500 Received: from [199.232.76.173] (port=44142 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBCXv-0007eN-Rb for qemu-devel@nongnu.org; Thu, 19 Nov 2009 14:19:59 -0500 Received: from moutng.kundenserver.de ([212.227.17.8]:50821) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NBCXv-0006jt-9q for qemu-devel@nongnu.org; Thu, 19 Nov 2009 14:19:59 -0500 From: Stefan Weil Date: Thu, 19 Nov 2009 20:19:56 +0100 Message-Id: <1258658396-10108-1-git-send-email-weil@mail.berlios.de> Subject: [Qemu-devel] [PATCH] Fix build for mingw32 on windows ($$ expansion) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU Developers Make using mingw32 on windows fails when running grep "=y$$". The command is expanded to grep "=y$ and the missing " results in an error. I don't expect a file config-devices.mak with =y somewhere in the middle of a line (they are always at the end of the line), so simplifying the regular expression to =y seems to be permitted. This avoids problems with wrong expansion. Signed-off-by: Stefan Weil --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index f8a5036..16ed995 100644 --- a/Makefile +++ b/Makefile @@ -35,7 +35,7 @@ SUBDIR_MAKEFLAGS=$(if $(V),,--no-print-directory) SUBDIR_DEVICES_MAK=$(patsubst %, %/config-devices.mak, $(TARGET_DIRS)) config-all-devices.mak: $(SUBDIR_DEVICES_MAK) - $(call quiet-command,cat $(SUBDIR_DEVICES_MAK) | grep "=y$$" | sort -u > $@," GEN $@") + $(call quiet-command,cat $(SUBDIR_DEVICES_MAK) | grep =y | sort -u > $@," GEN $@") -include config-all-devices.mak -- 1.5.6.5