From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NBY1X-00068X-4d for qemu-devel@nongnu.org; Fri, 20 Nov 2009 13:15:59 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NBY1S-00067I-K8 for qemu-devel@nongnu.org; Fri, 20 Nov 2009 13:15:58 -0500 Received: from [199.232.76.173] (port=41984 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBY1S-00067E-HI for qemu-devel@nongnu.org; Fri, 20 Nov 2009 13:15:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47513) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NBY1R-0005mG-Jg for qemu-devel@nongnu.org; Fri, 20 Nov 2009 13:15:54 -0500 From: Mark McLoughlin Date: Fri, 20 Nov 2009 18:13:10 +0000 Message-Id: <1258740790-26036-1-git-send-email-markmc@redhat.com> Subject: [Qemu-devel] [PATCH] slirp: fix use-after-free List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Mark McLoughlin , Jan Kiszka 460fec67ee introduced a use-after free in slirp. Cc: Jan Kiszka Signed-off-by: Mark McLoughlin --- Untested fix, but it's obvious. Also, this is needed on stable-0.11. slirp/mbuf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/slirp/mbuf.c b/slirp/mbuf.c index 7652fea..87508ba 100644 --- a/slirp/mbuf.c +++ b/slirp/mbuf.c @@ -95,8 +95,8 @@ m_free(struct mbuf *m) * Either free() it or put it on the free list */ if (m->m_flags & M_DOFREE) { - free(m); m->slirp->mbuf_alloced--; + free(m); } else if ((m->m_flags & M_FREELIST) == 0) { insque(m,&m->slirp->m_freelist); m->m_flags = M_FREELIST; /* Clobber other flags */ -- 1.6.2.5