qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <weil@mail.berlios.de>
To: QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH] Makefile: Add missing rule for config-devices.mak
Date: Sun, 22 Nov 2009 15:07:22 +0100	[thread overview]
Message-ID: <1258898842-5222-1-git-send-email-weil@mail.berlios.de> (raw)

All files config-devices.mak are copies from files in
directory default-configs.

Creating these copies during configuration ignores these
dependencies and may result in unresolved externals
from incremental builds when files in default-configs
are modified.

By adding a dependency rule to Makefile and executing
the copy commands there it is possible to run incremental
builds even with modified default-configs.

This is especially useful for git bisect.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 Makefile  |    3 +++
 configure |    4 ----
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/Makefile b/Makefile
index d770e2a..fdb47fb 100644
--- a/Makefile
+++ b/Makefile
@@ -41,6 +41,9 @@ SUBDIR_DEVICES_MAK=$(patsubst %, %/config-devices.mak, $(TARGET_DIRS))
 config-all-devices.mak: $(SUBDIR_DEVICES_MAK)
 	$(call quiet-command,cat $(SUBDIR_DEVICES_MAK) | grep "=y$$" | sort -u > $@,"  GEN   $@")
 
+%/config-devices.mak: default-configs/%.mak
+	$(call quiet-command,cp -p $< $@, "  GEN   $@")
+
 -include config-all-devices.mak
 
 build-all: $(DOCS) $(TOOLS) recurse-all
diff --git a/configure b/configure
index b65c11c..1223fc8 100755
--- a/configure
+++ b/configure
@@ -2209,10 +2209,6 @@ if test "$target" = "arm-linux-user" -o "$target" = "armeb-linux-user" -o "$targ
   mkdir -p $target_dir/nwfpe
 fi
 
-if test ! -f $target_dir/config-devices.mak ; then
-  cp $source_path/default-configs/${target}.mak $target_dir/config-devices.mak
-fi
-
 #
 # don't use ln -sf as not all "ln -sf" over write the file/link
 #
-- 
1.5.6.5

             reply	other threads:[~2009-11-22 14:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-22 14:07 Stefan Weil [this message]
2009-11-22 14:20 ` [Qemu-devel] [PATCH] Makefile: Add missing rule for config-devices.mak Scott Tsai
2009-11-23 18:55 ` Paul Brook
     [not found] ` <m33a45ia0a.fsf@neno.neno>
2009-11-26 10:25   ` [Qemu-devel] " Stefan Weil
2009-11-26 13:13     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258898842-5222-1-git-send-email-weil@mail.berlios.de \
    --to=weil@mail.berlios.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).