qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 07/10] default devices: vga adapter.
Date: Tue, 24 Nov 2009 09:58:41 +0100	[thread overview]
Message-ID: <1259053124-10471-8-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1259053124-10471-1-git-send-email-kraxel@redhat.com>

Qemu creates a vga display for you in case you didn't specify one on the
command line.  Right now this is tied to the '-vga <type>' command line
switch, which in turn causes trouble if you are creating your gfx card
using '-device VGA,<props>'.

This patch adds a variable default_vga which says whenever a default
serial line should be added.  It is enabled by default.  It is cleared
when qemu finds '-vga' or '-device {VGA,Cirrus VGA,QEMUware SVGA}' on
the command line.

'-device VGA' still doesn't work though due to a initialization order
issue (vga must init before calling i440fx_init_memory_mappings).

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 vl.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/vl.c b/vl.c
index e3d2ea3..eb1d23e 100644
--- a/vl.c
+++ b/vl.c
@@ -194,7 +194,7 @@ int autostart;
 static int rtc_utc = 1;
 static int rtc_date_offset = -1; /* -1 means no change */
 QEMUClock *rtc_clock;
-int vga_interface_type = VGA_CIRRUS;
+int vga_interface_type = VGA_NONE;
 #ifdef TARGET_SPARC
 int graphic_width = 1024;
 int graphic_height = 768;
@@ -276,6 +276,7 @@ static void *boot_set_opaque;
 static int default_serial = 1;
 static int default_parallel = 1;
 static int default_monitor = 1;
+static int default_vga = 1;
 
 static struct {
     const char *driver;
@@ -283,6 +284,9 @@ static struct {
 } default_list[] = {
     { .driver = "isa-serial",     .flag = &default_serial    },
     { .driver = "isa-parallel",   .flag = &default_parallel  },
+    { .driver = "VGA",            .flag = &default_vga       },
+    { .driver = "Cirrus VGA",     .flag = &default_vga       },
+    { .driver = "QEMUware SVGA",  .flag = &default_vga       },
 };
 
 static int default_driver_check(QemuOpts *opts, void *opaque)
@@ -4326,6 +4330,7 @@ static void select_vgahw (const char *p)
 {
     const char *opts;
 
+    default_vga = 0;
     vga_interface_type = VGA_NONE;
     if (strstart(p, "std", &opts)) {
         vga_interface_type = VGA_STD;
@@ -5507,6 +5512,8 @@ int main(int argc, char **argv, char **envp)
         if (default_monitor)
             add_device_config(DEV_MONITOR, "vc:80Cx24C");
     }
+    if (default_vga)
+        vga_interface_type = VGA_CIRRUS;
 
 #ifndef _WIN32
     if (daemonize) {
-- 
1.6.2.5

  parent reply	other threads:[~2009-11-24  8:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-24  8:58 [Qemu-devel] [PATCH 00/10] default devices: qdev integration Gerd Hoffmann
2009-11-24  8:58 ` [Qemu-devel] [PATCH 01/10] chardev: move greeting into vc backend Gerd Hoffmann
2009-11-24  8:58 ` [Qemu-devel] [PATCH 02/10] vc: colorize chardev title line with blue background Gerd Hoffmann
2009-11-24  8:58 ` [Qemu-devel] [PATCH 03/10] default devices: core code & serial lines Gerd Hoffmann
2009-11-24  8:58 ` [Qemu-devel] [PATCH 04/10] default devices: parallel port Gerd Hoffmann
2009-11-24  8:58 ` [Qemu-devel] [PATCH 05/10] default devices: qemu monitor Gerd Hoffmann
2009-11-24  8:58 ` [Qemu-devel] [PATCH 06/10] zap serial_monitor_mux Gerd Hoffmann
2009-11-24  8:58 ` Gerd Hoffmann [this message]
2009-11-24  8:58 ` [Qemu-devel] [PATCH 08/10] default devices: add global cmd line option Gerd Hoffmann
2009-11-24  8:58 ` [Qemu-devel] [PATCH 09/10] default devices: network Gerd Hoffmann
2009-11-24  8:58 ` [Qemu-devel] [PATCH 10/10] default devices: drives Gerd Hoffmann
2009-11-24  9:50 ` [Qemu-devel] [PATCH 00/10] default devices: qdev integration Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1259053124-10471-8-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).