* [Qemu-devel] [PATCH] eepro100: Allocate a larger buffer for regname()
@ 2009-11-26 2:20 David Benjamin
2009-11-27 9:31 ` Stefan Weil
0 siblings, 1 reply; 2+ messages in thread
From: David Benjamin @ 2009-11-26 2:20 UTC (permalink / raw)
To: qemu-devel
This should avoid truncating the register name when debugging.
Signed-off-by: David Benjamin <davidben@mit.edu>
---
hw/eepro100.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/eepro100.c b/hw/eepro100.c
index 8734907..3676dc0 100644
--- a/hw/eepro100.c
+++ b/hw/eepro100.c
@@ -648,7 +648,7 @@ static const char * const reg[PCI_IO_SIZE / 4] = {
static char *regname(uint32_t addr)
{
- static char buf[16];
+ static char buf[32];
if (addr < PCI_IO_SIZE) {
const char *r = reg[addr / 4];
if (r != 0) {
--
1.6.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] eepro100: Allocate a larger buffer for regname()
2009-11-26 2:20 [Qemu-devel] [PATCH] eepro100: Allocate a larger buffer for regname() David Benjamin
@ 2009-11-27 9:31 ` Stefan Weil
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Weil @ 2009-11-27 9:31 UTC (permalink / raw)
To: David Benjamin; +Cc: qemu-devel
David Benjamin schrieb:
> This should avoid truncating the register name when debugging.
>
> Signed-off-by: David Benjamin <davidben@mit.edu>
> ---
> hw/eepro100.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/eepro100.c b/hw/eepro100.c
> index 8734907..3676dc0 100644
> --- a/hw/eepro100.c
> +++ b/hw/eepro100.c
> @@ -648,7 +648,7 @@ static const char * const reg[PCI_IO_SIZE / 4] = {
>
> static char *regname(uint32_t addr)
> {
> - static char buf[16];
> + static char buf[32];
> if (addr < PCI_IO_SIZE) {
> const char *r = reg[addr / 4];
> if (r != 0) {
This was already fixed in the latest version of eepro100.c
(git://repo.or.cz/qemu/ar7.git).
In "official" QEMU on savannah, it is still missing
(as several other patches, too).
It takes more than a week to get a patch integrated...
Regards,
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-27 9:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-26 2:20 [Qemu-devel] [PATCH] eepro100: Allocate a larger buffer for regname() David Benjamin
2009-11-27 9:31 ` Stefan Weil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).