qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Glauber Costa <glommer@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [PATCH 5/7] tell kernel about all registers instead of just mp_state
Date: Thu, 26 Nov 2009 15:24:58 -0200	[thread overview]
Message-ID: <1259256300-23937-6-git-send-email-glommer@redhat.com> (raw)
In-Reply-To: <1259256300-23937-5-git-send-email-glommer@redhat.com>

This fix a bug with -smp in kvm. Since we have updated apic_base,
we also have to tell kernel about it. So instead of just updating
mp_state, update every regs.

Signed-off-by: Glauber Costa <glommer@redhat.com>
---
 hw/apic-kvm.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/hw/apic-kvm.c b/hw/apic-kvm.c
index e5a0bfc..dc61386 100644
--- a/hw/apic-kvm.c
+++ b/hw/apic-kvm.c
@@ -126,7 +126,10 @@ static void kvm_apic_reset(void *opaque)
     s->cpu_env->mp_state
             = bsp ? KVM_MP_STATE_RUNNABLE : KVM_MP_STATE_UNINITIALIZED;
 
-    kvm_put_mp_state(s->cpu_env);
+    /* We have to tell the kernel about mp_state, but also save sregs, since
+     * apic base was just updated
+     */
+    kvm_arch_put_registers(s->cpu_env);
 
     if (bsp) {
         /*
-- 
1.6.5.2

  reply	other threads:[~2009-11-26 17:25 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-26 17:24 [Qemu-devel] [PATCH 0/7] KVM SMP support, early version Glauber Costa
2009-11-26 17:24 ` [Qemu-devel] [PATCH 1/7] Don't mess with halted state Glauber Costa
2009-11-26 17:24   ` [Qemu-devel] [PATCH 2/7] store thread-specific env information Glauber Costa
2009-11-26 17:24     ` [Qemu-devel] [PATCH 3/7] update halted state on mp_state sync Glauber Costa
2009-11-26 17:24       ` [Qemu-devel] [PATCH 4/7] qemu_flush_work for remote vcpu execution Glauber Costa
2009-11-26 17:24         ` Glauber Costa [this message]
2009-11-26 17:24           ` [Qemu-devel] [PATCH 6/7] Don't call kvm cpu reset on initialization Glauber Costa
2009-11-26 17:25             ` [Qemu-devel] [PATCH 7/7] remove smp restriction from kvm Glauber Costa
2009-11-29 15:32           ` [Qemu-devel] [PATCH 5/7] tell kernel about all registers instead of just mp_state Avi Kivity
2009-11-30 11:45             ` Glauber Costa
2009-11-30 12:04               ` Gleb Natapov
2009-11-30 12:05               ` Avi Kivity
2009-11-30 13:31                 ` Glauber Costa
2009-11-30 13:32                   ` Avi Kivity
2009-11-29 15:32         ` [Qemu-devel] [PATCH 4/7] qemu_flush_work for remote vcpu execution Avi Kivity
2009-11-30 11:44           ` Glauber Costa
2009-11-30 12:06             ` Avi Kivity
2009-11-30 11:48         ` [Qemu-devel] " Paolo Bonzini
2009-11-29 15:29     ` [Qemu-devel] [PATCH 2/7] store thread-specific env information Avi Kivity
2009-11-29 15:38       ` Andreas Färber
2009-11-29 15:42         ` Avi Kivity
2009-11-29 16:00           ` Andreas Färber
2009-11-29 22:29           ` Jamie Lokier
2009-11-30 11:36         ` [Qemu-devel] " Paolo Bonzini
2009-11-30 11:41           ` Glauber Costa
2009-11-30 11:49             ` Paolo Bonzini
2009-11-30 12:07               ` Avi Kivity
2009-11-29 17:32 ` [Qemu-devel] Re: [PATCH 0/7] KVM SMP support, early version Jan Kiszka
2009-11-30 11:42   ` Glauber Costa
2009-11-30 15:55     ` Glauber Costa
2009-11-30 16:40       ` Avi Kivity
2009-11-30 16:47         ` Glauber Costa
2009-11-30 17:30           ` Jan Kiszka
2009-12-01 12:10             ` Avi Kivity
2009-12-01 12:17               ` Jan Kiszka
2009-12-01 12:20                 ` Glauber Costa
2009-12-01 12:33                   ` Jan Kiszka
2009-11-30 16:50         ` Avi Kivity
2009-12-01  0:31 ` [Qemu-devel] " Ed Swierk
2009-12-01  0:42   ` Ed Swierk
2009-12-01 12:20 ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1259256300-23937-6-git-send-email-glommer@redhat.com \
    --to=glommer@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).