From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NDpBP-0001c2-3m for qemu-devel@nongnu.org; Thu, 26 Nov 2009 19:59:35 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NDpBJ-0001WR-U4 for qemu-devel@nongnu.org; Thu, 26 Nov 2009 19:59:34 -0500 Received: from [199.232.76.173] (port=48288 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NDpBJ-0001WK-OA for qemu-devel@nongnu.org; Thu, 26 Nov 2009 19:59:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18732) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NDpBI-0004P1-UA for qemu-devel@nongnu.org; Thu, 26 Nov 2009 19:59:29 -0500 From: Luiz Capitulino Date: Thu, 26 Nov 2009 22:58:54 -0200 Message-Id: <1259283550-3597-5-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1259283550-3597-1-git-send-email-lcapitulino@redhat.com> References: <1259283550-3597-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 04/20] monitor: Introduce monitor_find_command() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, avi@redhat.com, armbru@redhat.com This commit moves the loop which searches for the command entry corresponding to a command name to its own function. It will be used by QMP code as well. Signed-off-by: Luiz Capitulino --- monitor.c | 22 +++++++++++++++------- 1 files changed, 15 insertions(+), 7 deletions(-) diff --git a/monitor.c b/monitor.c index e0cc941..6c2c1f1 100644 --- a/monitor.c +++ b/monitor.c @@ -3017,6 +3017,19 @@ static int is_valid_option(const char *c, const char *typestr) return (typestr != NULL); } +static const mon_cmd_t *monitor_find_command(const char *cmdname) +{ + const mon_cmd_t *cmd; + + for (cmd = mon_cmds; cmd->name != NULL; cmd++) { + if (compare_cmd(cmdname, cmd->name)) { + return cmd; + } + } + + return NULL; +} + static const mon_cmd_t *monitor_parse_command(Monitor *mon, const char *cmdline, QDict *qdict) @@ -3037,13 +3050,8 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon, if (!p) return NULL; - /* find the command */ - for(cmd = mon_cmds; cmd->name != NULL; cmd++) { - if (compare_cmd(cmdname, cmd->name)) - break; - } - - if (cmd->name == NULL) { + cmd = monitor_find_command(cmdname); + if (!cmd) { monitor_printf(mon, "unknown command: '%s'\n", cmdname); return NULL; } -- 1.6.6.rc0.50.gaf06e