Re: [Qemu-devel] [PULL 00/21] tcg patch queue

[Richard Henderson <richard.henderson@linaro.org>]

On 10/18/18 3:34 AM, Peter Maydell wrote:
> Hi; I get compile failures, I'm afraid:
> 
> FreeBSD's compiler gives warnings:
> In file included from /var/tmp/qemu-test.bVaUEj/accel/tcg/user-exec.c:28:
> /var/tmp/qemu-test.bVaUEj/include/qemu/atomic128.h:148:23: warning:
> unknown attribute 'error' ignored [-Wunknown-attributes]
> Int128 __attribute__((error("unsupported atomic")))
>                       ^
> /var/tmp/qemu-test.bVaUEj/include/qemu/atomic128.h:150:21: warning:
> unknown attribute 'error' ignored [-Wunknown-attributes]
> void __attribute__((error("unsupported atomic")))
>                     ^
> 
> x86-64 Linux clang fails with the same issue:
> In file included from
> /home/petmay01/linaro/qemu-for-merges/accel/tcg/user-exec.c:28:
> /home/petmay01/linaro/qemu-for-merges/include/qemu/atomic128.h:148:23:
> error: unknown attribute 'error' ignored
> [-Werror,-Wunknown-attributes]
> Int128 __attribute__((error("unsupported atomic")))
>                       ^
> /home/petmay01/linaro/qemu-for-merges/include/qemu/atomic128.h:150:21:
> error: unknown attribute 'error' ignored
> [-Werror,-Wunknown-attributes]
> void __attribute__((error("unsupported atomic")))

I used __has_attribute for this one.  Tested with clang 7.


> The win32 build fails with:
> 
> target/arm/helper-a64.o: In function `helper_paired_cmpxchg64_le_parallel':
> /home/petmay01/qemu-for-merges/target/arm/helper-a64.c:573: undefined
> reference to `helper_atomic_cmpxchgo_le_mmu'
> target/arm/helper-a64.o: In function `helper_paired_cmpxchg64_be_parallel':
> /home/petmay01/qemu-for-merges/target/arm/helper-a64.c:647: undefined
> reference to `helper_atomic_cmpxchgo_be_mmu'
> target/arm/helper-a64.o: In function `helper_casp_le_parallel':
> /home/petmay01/qemu-for-merges/target/arm/helper-a64.c:669: undefined
> reference to `helper_atomic_cmpxchgo_le_mmu'
> target/arm/helper-a64.o: In function `helper_casp_be_parallel':
> /home/petmay01/qemu-for-merges/target/arm/helper-a64.c:690: undefined
> reference to `helper_atomic_cmpxchgo_be_mmu'

This one I could not reproduce.  Tested with i686-w64-mingw32-gcc
and x86_64-w64-mingw32-gcc, both version 6.2.

I suspect configure misfired.  If you can, start this one over with a blank
build directory.

I've sent you a v2 pull.


r~