From: Glauber Costa <glommer@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, avi@redhat.com, agraf@suse.de
Subject: [Qemu-devel] [PATCH v2 11/11] remove smp restriction from kvm
Date: Tue, 1 Dec 2009 10:51:37 -0200 [thread overview]
Message-ID: <1259671897-22232-12-git-send-email-glommer@redhat.com> (raw)
In-Reply-To: <1259671897-22232-11-git-send-email-glommer@redhat.com>
We don't support smp without irqchip in kernel, so only abort in
that situation
Signed-off-by: Glauber Costa <glommer@redhat.com>
---
kvm-all.c | 17 ++++++++++-------
1 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index 286d0ee..db5daf6 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -438,15 +438,23 @@ static int kvm_create_irqchip(KVMState *s)
{
int ret = 0;
#if defined(CONFIG_IOTHREAD)
+ ret = -1;
if (!kvm_check_extension(s, KVM_CAP_IRQCHIP))
- return -1;
+ goto failed;
ret = kvm_vm_ioctl(s, KVM_CREATE_IRQCHIP);
if (ret < 0)
- return ret;
+ goto failed;
s->irqchip_in_kernel = 1;
+
+ return ret;
+failed:
#endif
+ if (smp_cpus > 1) {
+ fprintf(stderr, "No SMP KVM support, use '-smp 1'\n");
+ ret = -EINVAL;
+ }
return ret;
}
@@ -459,11 +467,6 @@ int kvm_init(int smp_cpus)
int ret;
int i;
- if (smp_cpus > 1) {
- fprintf(stderr, "No SMP KVM support, use '-smp 1'\n");
- return -EINVAL;
- }
-
s = qemu_mallocz(sizeof(KVMState));
#ifdef KVM_CAP_SET_GUEST_DEBUG
--
1.6.5.2
next prev parent reply other threads:[~2009-12-01 12:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 12:51 [Qemu-devel] [PATCH v2 0/11] Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 01/11] Don't mess with halted state Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 02/11] store thread-specific env information Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 03/11] update halted state on mp_state sync Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 04/11] qemu_flush_work for remote vcpu execution Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 05/11] tell kernel about all registers instead of just mp_state Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 06/11] flush state in migration post_load Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 07/11] Don't call kvm cpu reset on initialization Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 08/11] use cpu_kick instead of direct signalling Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 09/11] Use per-cpu reset handlers Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 10/11] Use __thread where available Glauber Costa
2009-12-01 12:51 ` Glauber Costa [this message]
2009-12-02 10:48 ` [Qemu-devel] [PATCH v2 05/11] tell kernel about all registers instead of just mp_state Gleb Natapov
2009-12-02 11:22 ` Glauber Costa
2009-12-02 12:10 ` [Qemu-devel] " Jan Kiszka
2009-12-02 12:26 ` Gleb Natapov
2009-12-02 12:35 ` Jan Kiszka
2009-12-02 13:27 ` [Qemu-devel] [PATCH v2 04/11] qemu_flush_work for remote vcpu execution Marcelo Tosatti
2009-12-02 13:41 ` Glauber Costa
2009-12-02 13:54 ` Marcelo Tosatti
2009-12-02 14:01 ` Glauber Costa
2009-12-02 10:59 ` [Qemu-devel] [PATCH v2 0/11] Gleb Natapov
2009-12-02 12:00 ` Glauber Costa
2009-12-02 12:04 ` [Qemu-devel] " Jan Kiszka
2009-12-02 12:22 ` Gleb Natapov
2009-12-02 12:25 ` Jan Kiszka
2009-12-02 12:30 ` Gleb Natapov
2009-12-02 12:33 ` Jan Kiszka
2009-12-02 12:49 ` Gleb Natapov
2009-12-03 7:33 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259671897-22232-12-git-send-email-glommer@redhat.com \
--to=glommer@redhat.com \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).