From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFSCy-0005Vg-EL for qemu-devel@nongnu.org; Tue, 01 Dec 2009 07:51:56 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFSCs-0005UM-P3 for qemu-devel@nongnu.org; Tue, 01 Dec 2009 07:51:55 -0500 Received: from [199.232.76.173] (port=35004 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFSCr-0005U2-72 for qemu-devel@nongnu.org; Tue, 01 Dec 2009 07:51:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:20061) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NFSCq-0004rD-Uu for qemu-devel@nongnu.org; Tue, 01 Dec 2009 07:51:49 -0500 From: Glauber Costa Date: Tue, 1 Dec 2009 10:51:27 -0200 Message-Id: <1259671897-22232-2-git-send-email-glommer@redhat.com> In-Reply-To: <1259671897-22232-1-git-send-email-glommer@redhat.com> References: <1259671897-22232-1-git-send-email-glommer@redhat.com> Subject: [Qemu-devel] [PATCH v2 01/11] Don't mess with halted state. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, avi@redhat.com, agraf@suse.de When we have irqchip in kernel, halted state is kernel business. So don't initialize it in our code. Signed-off-by: Glauber Costa --- hw/apic-kvm.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/apic-kvm.c b/hw/apic-kvm.c index 089fa45..e5a0bfc 100644 --- a/hw/apic-kvm.c +++ b/hw/apic-kvm.c @@ -122,10 +122,9 @@ static void kvm_apic_reset(void *opaque) s->dev.next_time = 0; s->dev.wait_for_sipi = 1; - s->cpu_env->halted = !(s->dev.apicbase & MSR_IA32_APICBASE_BSP); s->cpu_env->mp_state - = s->cpu_env->halted ? KVM_MP_STATE_UNINITIALIZED : KVM_MP_STATE_RUNNABLE; + = bsp ? KVM_MP_STATE_RUNNABLE : KVM_MP_STATE_UNINITIALIZED; kvm_put_mp_state(s->cpu_env); -- 1.6.5.2