qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Glauber Costa <glommer@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, avi@redhat.com
Subject: [Qemu-devel] [PATCH 10/11] Use __thread where available.
Date: Wed,  2 Dec 2009 11:48:21 -0200	[thread overview]
Message-ID: <1259761702-4041-11-git-send-email-glommer@redhat.com> (raw)
In-Reply-To: <1259761702-4041-10-git-send-email-glommer@redhat.com>

It is much faster than pthread_{g,s}et_specific.

Signed-off-by: Glauber Costa <glommer@redhat.com>
---
 configure |   17 +++++++++++++++++
 vl.c      |   16 ++++++++++++++++
 2 files changed, 33 insertions(+), 0 deletions(-)

diff --git a/configure b/configure
index dca5a43..ce7bcc4 100755
--- a/configure
+++ b/configure
@@ -233,6 +233,7 @@ blobs="yes"
 pkgversion=""
 check_utests="no"
 user_pie="no"
+tls_thread="yes"
 
 # OS specific
 if check_define __linux__ ; then
@@ -1017,6 +1018,19 @@ EOF
 fi
 
 ##########################################
+# Check for availability of the __thread keyword
+cat > $TMPC <<EOF
+__thread void *ptr;
+int main(void) { return 0;}
+EOF
+
+if compile_prog; then
+    tls_thread="yes"
+else
+    tls_thread="no"
+fi
+
+##########################################
 # VNC TLS detection
 if test "$vnc_tls" != "no" ; then
   cat > $TMPC <<EOF
@@ -1969,6 +1983,9 @@ echo "CONFIG_BDRV_WHITELIST=$block_drv_whitelist" >> $config_host_mak
 if test "$mixemu" = "yes" ; then
   echo "CONFIG_MIXEMU=y" >> $config_host_mak
 fi
+if test "$tls_thread" = "yes" ; then
+  echo "CONFIG_TLS_HAS_THREAD=y" >> $config_host_mak
+fi
 if test "$vnc_tls" = "yes" ; then
   echo "CONFIG_VNC_TLS=y" >> $config_host_mak
   echo "VNC_TLS_CFLAGS=$vnc_tls_cflags" >> $config_host_mak
diff --git a/vl.c b/vl.c
index ad2e7d6..16a41e3 100644
--- a/vl.c
+++ b/vl.c
@@ -3445,21 +3445,37 @@ static void block_io_signals(void);
 static void unblock_io_signals(void);
 static int tcg_has_work(void);
 
+#ifdef CONFIG_TLS_HAS_THREAD
+static __thread CPUState *current_env;
+#else
 static pthread_key_t current_env;
+#endif
 
 static CPUState *qemu_get_current_env(void)
 {
+#ifdef CONFIG_TLS_HAS_THREAD
+    return current_env;
+#else
     return pthread_getspecific(current_env);
+#endif
 }
 
 static void qemu_set_current_env(CPUState *env)
 {
+#ifdef CONFIG_TLS_HAS_THREAD
+    current_env = env;
+#else
     pthread_setspecific(current_env, env);
+#endif
 }
 
 static void qemu_init_current_env(void)
 {
+#ifdef CONFIG_TLS_HAS_THREAD
+    current_env = NULL;
+#else
     pthread_key_create(&current_env, NULL);
+#endif
 }
 
 static int qemu_init_main_loop(void)
-- 
1.6.5.2

  reply	other threads:[~2009-12-02 13:48 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-02 13:48 [Qemu-devel] [PATCH 00/11] SMP support in qemu.git Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 01/11] Don't mess with halted state Glauber Costa
2009-12-02 13:48   ` [Qemu-devel] [PATCH 02/11] store thread-specific env information Glauber Costa
2009-12-02 13:48     ` [Qemu-devel] [PATCH 03/11] update halted state on mp_state sync Glauber Costa
2009-12-02 13:48       ` [Qemu-devel] [PATCH 04/11] qemu_flush_work for remote vcpu execution Glauber Costa
2009-12-02 13:48         ` [Qemu-devel] [PATCH 05/11] tell kernel about all registers instead of just mp_state Glauber Costa
2009-12-02 13:48           ` [Qemu-devel] [PATCH 06/11] flush state in migration post_load Glauber Costa
2009-12-02 13:48             ` [Qemu-devel] [PATCH 07/11] Don't call kvm cpu reset on initialization Glauber Costa
2009-12-02 13:48               ` [Qemu-devel] [PATCH 08/11] use cpu_kick instead of direct signalling Glauber Costa
2009-12-02 13:48                 ` [Qemu-devel] [PATCH 09/11] Use per-cpu reset handlers Glauber Costa
2009-12-02 13:48                   ` Glauber Costa [this message]
2009-12-02 13:48                     ` [Qemu-devel] [PATCH 11/11] remove smp restriction from kvm Glauber Costa
2009-12-03 12:23                       ` [Qemu-devel] " Avi Kivity
2009-12-03 12:36                         ` Glauber Costa
2009-12-03 12:37                           ` Avi Kivity
2009-12-03 12:39                             ` Glauber Costa
2009-12-03 12:40                               ` Avi Kivity
2009-12-03 12:20         ` [Qemu-devel] Re: [PATCH 04/11] qemu_flush_work for remote vcpu execution Avi Kivity
2009-12-03 12:33           ` Glauber Costa
2009-12-03 12:35             ` Avi Kivity
2009-12-03 12:37               ` Glauber Costa
2009-12-03 12:40                 ` Avi Kivity
2009-12-03 14:29         ` Paolo Bonzini
2009-12-03 15:02           ` Glauber Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1259761702-4041-11-git-send-email-glommer@redhat.com \
    --to=glommer@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).