From: Glauber Costa <glommer@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, avi@redhat.com
Subject: [Qemu-devel] [PATCH 01/11] Don't mess with halted state.
Date: Wed, 2 Dec 2009 11:48:12 -0200 [thread overview]
Message-ID: <1259761702-4041-2-git-send-email-glommer@redhat.com> (raw)
In-Reply-To: <1259761702-4041-1-git-send-email-glommer@redhat.com>
When we have irqchip in kernel, halted state is kernel
business. So don't initialize it in our code.
Signed-off-by: Glauber Costa <glommer@redhat.com>
---
hw/apic-kvm.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/apic-kvm.c b/hw/apic-kvm.c
index 089fa45..e5a0bfc 100644
--- a/hw/apic-kvm.c
+++ b/hw/apic-kvm.c
@@ -122,10 +122,9 @@ static void kvm_apic_reset(void *opaque)
s->dev.next_time = 0;
s->dev.wait_for_sipi = 1;
- s->cpu_env->halted = !(s->dev.apicbase & MSR_IA32_APICBASE_BSP);
s->cpu_env->mp_state
- = s->cpu_env->halted ? KVM_MP_STATE_UNINITIALIZED : KVM_MP_STATE_RUNNABLE;
+ = bsp ? KVM_MP_STATE_RUNNABLE : KVM_MP_STATE_UNINITIALIZED;
kvm_put_mp_state(s->cpu_env);
--
1.6.5.2
next prev parent reply other threads:[~2009-12-02 13:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 13:48 [Qemu-devel] [PATCH 00/11] SMP support in qemu.git Glauber Costa
2009-12-02 13:48 ` Glauber Costa [this message]
2009-12-02 13:48 ` [Qemu-devel] [PATCH 02/11] store thread-specific env information Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 03/11] update halted state on mp_state sync Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 04/11] qemu_flush_work for remote vcpu execution Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 05/11] tell kernel about all registers instead of just mp_state Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 06/11] flush state in migration post_load Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 07/11] Don't call kvm cpu reset on initialization Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 08/11] use cpu_kick instead of direct signalling Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 09/11] Use per-cpu reset handlers Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 10/11] Use __thread where available Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 11/11] remove smp restriction from kvm Glauber Costa
2009-12-03 12:23 ` [Qemu-devel] " Avi Kivity
2009-12-03 12:36 ` Glauber Costa
2009-12-03 12:37 ` Avi Kivity
2009-12-03 12:39 ` Glauber Costa
2009-12-03 12:40 ` Avi Kivity
2009-12-03 12:20 ` [Qemu-devel] Re: [PATCH 04/11] qemu_flush_work for remote vcpu execution Avi Kivity
2009-12-03 12:33 ` Glauber Costa
2009-12-03 12:35 ` Avi Kivity
2009-12-03 12:37 ` Glauber Costa
2009-12-03 12:40 ` Avi Kivity
2009-12-03 14:29 ` Paolo Bonzini
2009-12-03 15:02 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259761702-4041-2-git-send-email-glommer@redhat.com \
--to=glommer@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).