From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFpZM-0006Ve-SP for qemu-devel@nongnu.org; Wed, 02 Dec 2009 08:48:37 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFpZK-0006Tt-9s for qemu-devel@nongnu.org; Wed, 02 Dec 2009 08:48:35 -0500 Received: from [199.232.76.173] (port=58153 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFpZJ-0006Ta-SO for qemu-devel@nongnu.org; Wed, 02 Dec 2009 08:48:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11354) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NFpZJ-0004GU-IE for qemu-devel@nongnu.org; Wed, 02 Dec 2009 08:48:33 -0500 From: Glauber Costa Date: Wed, 2 Dec 2009 11:48:16 -0200 Message-Id: <1259761702-4041-6-git-send-email-glommer@redhat.com> In-Reply-To: <1259761702-4041-5-git-send-email-glommer@redhat.com> References: <1259761702-4041-1-git-send-email-glommer@redhat.com> <1259761702-4041-2-git-send-email-glommer@redhat.com> <1259761702-4041-3-git-send-email-glommer@redhat.com> <1259761702-4041-4-git-send-email-glommer@redhat.com> <1259761702-4041-5-git-send-email-glommer@redhat.com> Subject: [Qemu-devel] [PATCH 05/11] tell kernel about all registers instead of just mp_state List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, avi@redhat.com This fix a bug with -smp in kvm. Since we have updated apic_base, we also have to tell kernel about it. So instead of just updating mp_state, update every regs. It is mandatory that this happens synchronously, without waiting for the next vcpu run. Otherwise, if we are migrating, or initializing the cpu's APIC, other cpus can still see an invalid state. Since putting registers already happen in vcpu entry, we factor out the required code in cpu_flush_state() Signed-off-by: Glauber Costa --- hw/apic-kvm.c | 5 ++++- kvm-all.c | 13 +++++++++---- kvm.h | 8 ++++++++ 3 files changed, 21 insertions(+), 5 deletions(-) diff --git a/hw/apic-kvm.c b/hw/apic-kvm.c index e5a0bfc..9e9790f 100644 --- a/hw/apic-kvm.c +++ b/hw/apic-kvm.c @@ -126,7 +126,10 @@ static void kvm_apic_reset(void *opaque) s->cpu_env->mp_state = bsp ? KVM_MP_STATE_RUNNABLE : KVM_MP_STATE_UNINITIALIZED; - kvm_put_mp_state(s->cpu_env); + /* We have to tell the kernel about mp_state, but also save sregs, since + * apic base was just updated + */ + cpu_flush_state(s->cpu_env); if (bsp) { /* diff --git a/kvm-all.c b/kvm-all.c index f7d89c6..596416a 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -612,6 +612,14 @@ void kvm_cpu_synchronize_state(CPUState *env) } } +void kvm_cpu_flush_state(CPUState *env) +{ + if (env->kvm_state->regs_modified) { + kvm_arch_put_registers(env); + env->kvm_state->regs_modified = 0; + } +} + int kvm_cpu_exec(CPUState *env) { struct kvm_run *run = env->kvm_run; @@ -626,10 +634,7 @@ int kvm_cpu_exec(CPUState *env) break; } - if (env->kvm_state->regs_modified) { - kvm_arch_put_registers(env); - env->kvm_state->regs_modified = 0; - } + kvm_cpu_flush_state(env); kvm_arch_pre_run(env, run); qemu_mutex_unlock_iothread(); diff --git a/kvm.h b/kvm.h index 15fb34a..7b9d8b3 100644 --- a/kvm.h +++ b/kvm.h @@ -144,6 +144,7 @@ int kvm_check_extension(KVMState *s, unsigned int extension); uint32_t kvm_arch_get_supported_cpuid(CPUState *env, uint32_t function, int reg); void kvm_cpu_synchronize_state(CPUState *env); +void kvm_cpu_flush_state(CPUState *env); /* generic hooks - to be moved/refactored once there are more users */ @@ -154,4 +155,11 @@ static inline void cpu_synchronize_state(CPUState *env) } } +static inline void cpu_flush_state(CPUState *env) +{ + if (kvm_enabled()) { + kvm_cpu_flush_state(env); + } +} + #endif -- 1.6.5.2