From: Alexander Graf <agraf@suse.de>
To: qemu-devel@nongnu.org
Cc: Kevin O'Connor <kevin@koconnor.net>,
Gleb Natapov <gleb@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Sebastian Herbszt <herbszt@gmx.de>
Subject: [Qemu-devel] [PATCH v2] [0.12] Map BIOS f-segment as RAM, not as ROM
Date: Fri, 4 Dec 2009 11:33:13 +0100 [thread overview]
Message-ID: <1259922793-20433-1-git-send-email-agraf@suse.de> (raw)
SeaBIOS needs to write to the f-segment. So it needs to have some way to set
that from read-only to read-write, write in it and when it's done set it to
read-only again.
On PCI we have a mechanism for that. The ISA machine does not though. To stay
regression free and happily enable users to continue using the -M isapc machine
let's just map it as RAM. The BIOS on PCI will set it to r/o later either way.
Signed-off-by: Alexander Graf <agraf@suse.de>
---
v1 -> v2:
- always map r/w
---
hw/pc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index 8c1b7ea..b5dabdd 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -1075,7 +1075,7 @@ static void pc_init1(ram_addr_t ram_size,
isa_bios_size = 128 * 1024;
cpu_register_physical_memory(0x100000 - isa_bios_size,
isa_bios_size,
- (bios_offset + bios_size - isa_bios_size) | IO_MEM_ROM);
+ (bios_offset + bios_size - isa_bios_size));
--
1.6.0.2
next reply other threads:[~2009-12-04 10:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 10:33 Alexander Graf [this message]
2009-12-04 13:48 ` [Qemu-devel] Re: [PATCH v2] [0.12] Map BIOS f-segment as RAM, not as ROM Anthony Liguori
2009-12-04 14:10 ` Gleb Natapov
2009-12-05 16:31 ` Kevin O'Connor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259922793-20433-1-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=gleb@redhat.com \
--cc=herbszt@gmx.de \
--cc=kevin@koconnor.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).