From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [PATCH 05/17] monitor: Fix do_info_balloon() output
Date: Fri, 4 Dec 2009 15:11:23 -0200 [thread overview]
Message-ID: <1259946695-15784-6-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1259946695-15784-1-git-send-email-lcapitulino@redhat.com>
New monitor commands should always return values in bytes.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
monitor.c | 12 +++++++++---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index 5bf32f0..8cedfa9 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1889,12 +1889,18 @@ static void do_balloon(Monitor *mon, const QDict *qdict, QObject **ret_data)
static void monitor_print_balloon(Monitor *mon, const QObject *data)
{
- monitor_printf(mon, "balloon: actual=%d\n",
- (int)qint_get_int(qobject_to_qint(data)));
+ monitor_printf(mon, "balloon: actual=%" PRId64 "\n",
+ qint_get_int(qobject_to_qint(data)) >> 20);
}
/**
* do_info_balloon(): Balloon information
+ *
+ * Return a QInt with current ballooning value.
+ *
+ * Example:
+ *
+ * 1073741824
*/
static void do_info_balloon(Monitor *mon, QObject **ret_data)
{
@@ -1906,7 +1912,7 @@ static void do_info_balloon(Monitor *mon, QObject **ret_data)
else if (actual == 0)
qemu_error_new(QERR_DEVICE_NOT_ACTIVE, "balloon");
else
- *ret_data = QOBJECT(qint_from_int((int)(actual >> 20)));
+ *ret_data = QOBJECT(qint_from_int(actual));
}
static qemu_acl *find_acl(Monitor *mon, const char *name)
--
1.6.6.rc1.5.ge21a85
next prev parent reply other threads:[~2009-12-04 17:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 17:11 [Qemu-devel] [FOR 0.12 v2 00/17]: info handlers conversions to QObject Luiz Capitulino
2009-12-04 17:11 ` [Qemu-devel] [PATCH 01/17] Introduce qemu-objects.h header file Luiz Capitulino
2009-12-04 17:11 ` [Qemu-devel] [PATCH 02/17] Makefile: move QObject objs to their own entry Luiz Capitulino
2009-12-04 17:11 ` [Qemu-devel] [PATCH 03/17] QDict: Introduce qdict_get_qbool() Luiz Capitulino
2009-12-04 17:11 ` [Qemu-devel] [PATCH 04/17] QDict: Introduce qdict_get_qlist() Luiz Capitulino
2009-12-04 17:11 ` Luiz Capitulino [this message]
2009-12-07 19:41 ` [Qemu-devel] [PATCH 05/17] monitor: Fix do_info_balloon() output Anthony Liguori
2009-12-04 17:11 ` [Qemu-devel] [PATCH 06/17] monitor: Convert do_info_status() to QObject Luiz Capitulino
2009-12-07 19:31 ` Anthony Liguori
2009-12-04 17:11 ` [Qemu-devel] [PATCH 07/17] monitor: Convert do_info_kvm() " Luiz Capitulino
2009-12-07 19:34 ` Anthony Liguori
2009-12-04 17:11 ` [Qemu-devel] [PATCH 08/17] monitor: Convert do_info_name() " Luiz Capitulino
2009-12-04 17:11 ` [Qemu-devel] [PATCH 09/17] monitor: Convert do_info_hpet() " Luiz Capitulino
2009-12-04 17:11 ` [Qemu-devel] [PATCH 10/17] monitor: Convert do_info_uuid() " Luiz Capitulino
2009-12-04 17:11 ` [Qemu-devel] [PATCH 11/17] monitor: Convert do_info_mice() " Luiz Capitulino
2009-12-04 17:11 ` [Qemu-devel] [PATCH 12/17] migration: Convert do_info_migrate() " Luiz Capitulino
2009-12-07 19:38 ` Anthony Liguori
2009-12-04 17:11 ` [Qemu-devel] [PATCH 13/17] block: Convert bdrv_info() " Luiz Capitulino
2009-12-04 17:11 ` [Qemu-devel] [PATCH 14/17] block: Convert bdrv_info_stats() " Luiz Capitulino
2009-12-04 17:11 ` [Qemu-devel] [PATCH 15/17] char: Convert qemu_chr_info() " Luiz Capitulino
2009-12-04 17:11 ` [Qemu-devel] [PATCH 16/17] PCI: Convert pci_device_hot_add() " Luiz Capitulino
2009-12-04 17:11 ` [Qemu-devel] [PATCH 17/17] VNC: Convert do_info_vnc() " Luiz Capitulino
-- strict thread matches above, loose matches on Subject: below --
2009-11-23 20:06 [Qemu-devel] [PATCH v1 00/17]: info handlers conversions " Luiz Capitulino
2009-11-23 20:06 ` [Qemu-devel] [PATCH 05/17] monitor: Fix do_info_balloon() output Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259946695-15784-6-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).