qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Faerber <andreas.faerber@web.de>
To: qemu-devel@nongnu.org
Cc: John Arbuckle <programmingkidx@gmail.com>,
	Andreas Faerber <andreas.faerber@web.de>
Subject: [Qemu-devel] [PATCH 3/3] Cocoa: Silence warnings
Date: Sun,  6 Dec 2009 05:57:57 +0100	[thread overview]
Message-ID: <1260075477-76209-4-git-send-email-andreas.faerber@web.de> (raw)
In-Reply-To: <1260075477-76209-3-git-send-email-andreas.faerber@web.de>

Missing static for cocoa_keycode_to_qemu.
Missing const for character constant.

__LITTLE_ENDIAN__ is undefined on Big Endian host.

Signed-off-by: Andreas Faerber <andreas.faerber@web.de>
Cc: John Arbuckle <programmingkidx@gmail.com>
---
 cocoa.m |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/cocoa.m b/cocoa.m
index 7062571..05f507d 100644
--- a/cocoa.m
+++ b/cocoa.m
@@ -229,7 +229,7 @@ int keymap[] =
 */
 };
 
-int cocoa_keycode_to_qemu(int keycode)
+static int cocoa_keycode_to_qemu(int keycode)
 {
     if((sizeof(keymap)/sizeof(int)) <= keycode)
     {
@@ -315,7 +315,7 @@ int cocoa_keycode_to_qemu(int keycode)
             screen.bitsPerComponent, //bitsPerComponent
             screen.bitsPerPixel, //bitsPerPixel
             (screen.width * (screen.bitsPerComponent/2)), //bytesPerRow
-#if __LITTLE_ENDIAN__
+#ifdef __LITTLE_ENDIAN__
             CGColorSpaceCreateWithName(kCGColorSpaceGenericRGB), //colorspace for OS X >= 10.4
             kCGBitmapByteOrder32Little | kCGImageAlphaNoneSkipFirst,
 #else
@@ -783,7 +783,7 @@ int cocoa_keycode_to_qemu(int keycode)
     if(returnCode == NSCancelButton) {
         exit(0);
     } else if(returnCode == NSOKButton) {
-        char *bin = "qemu";
+        const char *bin = "qemu";
         char *img = (char*)[ [ sheet filename ] cStringUsingEncoding:NSASCIIStringEncoding];
 
         char **argv = (char**)malloc( sizeof(char*)*3 );
-- 
1.6.5.3

  reply	other threads:[~2009-12-06  4:58 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-06  4:57 [Qemu-devel] Adding support for Mac OS X ppc64 host Andreas Faerber
2009-12-06  4:57 ` [Qemu-devel] [PATCH 1/3] TCG: Mac OS X support for ppc64 target Andreas Faerber
2009-12-06  4:57   ` [Qemu-devel] [PATCH 2/3] Cocoa: ppc64 host support Andreas Faerber
2009-12-06  4:57     ` Andreas Faerber [this message]
2009-12-06  5:13   ` [Qemu-devel] Re: [PATCH 1/3] TCG: Mac OS X support for ppc64 target malc
2009-12-06  5:25     ` Andreas Färber
2009-12-06  6:28       ` malc
2009-12-06 13:00         ` [Qemu-devel] [PATCH v2 " Andreas Faerber
2009-12-06 13:00           ` [Qemu-devel] [PATCH v2 2/3] Cocoa: ppc64 host support Andreas Faerber
2009-12-06 13:00             ` [Qemu-devel] [PATCH v2 3/3] Cocoa: Silence warnings Andreas Faerber
2009-12-06 13:02             ` [Qemu-devel] Re: [PATCH v2 2/3] Cocoa: ppc64 host support Alexander Graf
2009-12-06 13:23               ` Andreas Färber
2009-12-06 13:32                 ` Alexander Graf
2009-12-06 13:41             ` Mike Kronenberg
2009-12-06 14:09               ` Andreas Färber
2009-12-06 15:21                 ` [Qemu-devel] [PATCH v3 1/3] TCG: Mac OS X support for ppc64 target Andreas Faerber
2009-12-06 15:21                   ` [Qemu-devel] [PATCH v3 2/3] Cocoa: ppc64 host support Andreas Faerber
2009-12-06 15:21                     ` [Qemu-devel] [PATCH v3 3/3] Cocoa: Silence warnings Andreas Faerber
2009-12-06 13:08         ` [Qemu-devel] Re: [PATCH 1/3] TCG: Mac OS X support for ppc64 target Andreas Färber
2009-12-06  5:14 ` [Qemu-devel] Adding support for Mac OS X ppc64 host malc
2009-12-06  5:41   ` Andreas Färber
2009-12-06  6:37     ` malc
2009-12-11 21:32       ` Andreas Färber
2009-12-12 13:00         ` malc
2009-12-15 17:00         ` malc
2009-12-15 22:36           ` Andreas Färber
2009-12-12  1:21       ` Andreas Färber
2009-12-12 12:58         ` malc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1260075477-76209-4-git-send-email-andreas.faerber@web.de \
    --to=andreas.faerber@web.de \
    --cc=programmingkidx@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).