From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NH9Cb-000411-Df for qemu-devel@nongnu.org; Sat, 05 Dec 2009 23:58:33 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NH9CV-0003zN-Sb for qemu-devel@nongnu.org; Sat, 05 Dec 2009 23:58:32 -0500 Received: from [199.232.76.173] (port=37975 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NH9CV-0003zF-El for qemu-devel@nongnu.org; Sat, 05 Dec 2009 23:58:27 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:59025) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NH9CV-0006MP-0d for qemu-devel@nongnu.org; Sat, 05 Dec 2009 23:58:27 -0500 From: Andreas Faerber Date: Sun, 6 Dec 2009 05:57:57 +0100 Message-Id: <1260075477-76209-4-git-send-email-andreas.faerber@web.de> In-Reply-To: <1260075477-76209-3-git-send-email-andreas.faerber@web.de> References: <1260075477-76209-1-git-send-email-andreas.faerber@web.de> <1260075477-76209-2-git-send-email-andreas.faerber@web.de> <1260075477-76209-3-git-send-email-andreas.faerber@web.de> Sender: andreas.faerber@web.de Subject: [Qemu-devel] [PATCH 3/3] Cocoa: Silence warnings List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: John Arbuckle , Andreas Faerber Missing static for cocoa_keycode_to_qemu. Missing const for character constant. __LITTLE_ENDIAN__ is undefined on Big Endian host. Signed-off-by: Andreas Faerber Cc: John Arbuckle --- cocoa.m | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cocoa.m b/cocoa.m index 7062571..05f507d 100644 --- a/cocoa.m +++ b/cocoa.m @@ -229,7 +229,7 @@ int keymap[] = */ }; -int cocoa_keycode_to_qemu(int keycode) +static int cocoa_keycode_to_qemu(int keycode) { if((sizeof(keymap)/sizeof(int)) <= keycode) { @@ -315,7 +315,7 @@ int cocoa_keycode_to_qemu(int keycode) screen.bitsPerComponent, //bitsPerComponent screen.bitsPerPixel, //bitsPerPixel (screen.width * (screen.bitsPerComponent/2)), //bytesPerRow -#if __LITTLE_ENDIAN__ +#ifdef __LITTLE_ENDIAN__ CGColorSpaceCreateWithName(kCGColorSpaceGenericRGB), //colorspace for OS X >= 10.4 kCGBitmapByteOrder32Little | kCGImageAlphaNoneSkipFirst, #else @@ -783,7 +783,7 @@ int cocoa_keycode_to_qemu(int keycode) if(returnCode == NSCancelButton) { exit(0); } else if(returnCode == NSOKButton) { - char *bin = "qemu"; + const char *bin = "qemu"; char *img = (char*)[ [ sheet filename ] cStringUsingEncoding:NSASCIIStringEncoding]; char **argv = (char**)malloc( sizeof(char*)*3 ); -- 1.6.5.3