qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, agraf@suse.de, lcapitulino@redhat.com
Subject: [Qemu-devel] [FOR 0.12 PATCH v4 20/22] add -qmp convinience switch
Date: Tue,  8 Dec 2009 13:11:52 +0100	[thread overview]
Message-ID: <1260274314-2906-21-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1260274314-2906-1-git-send-email-kraxel@redhat.com>

Acts like -monitor but switched into qmp mode.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 qemu-options.hx |    2 ++
 vl.c            |   14 +++++++++-----
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 7234447..b8cc375 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1588,6 +1588,8 @@ serial port).
 The default device is @code{vc} in graphical mode and @code{stdio} in
 non graphical mode.
 ETEXI
+DEF("qmp", HAS_ARG, QEMU_OPTION_qmp, \
+    "-qmp dev        like -monitor but opens in 'control' mode.\n")
 
 DEF("mon", HAS_ARG, QEMU_OPTION_mon, \
     "-mon chardev=[name][,mode=readline|control][,default]\n")
diff --git a/vl.c b/vl.c
index d90975f..ab77c35 100644
--- a/vl.c
+++ b/vl.c
@@ -4660,7 +4660,7 @@ static int mon_init_func(QemuOpts *opts, void *opaque)
     return 0;
 }
 
-static void monitor_parse(const char *optarg)
+static void monitor_parse(const char *optarg, const char *mode)
 {
     static int monitor_device_index = 0;
     QemuOpts *opts;
@@ -4690,7 +4690,7 @@ static void monitor_parse(const char *optarg)
         fprintf(stderr, "duplicate chardev: %s\n", label);
         exit(1);
     }
-    qemu_opt_set(opts, "mode", "readline");
+    qemu_opt_set(opts, "mode", mode);
     qemu_opt_set(opts, "chardev", label);
     if (def)
         qemu_opt_set(opts, "default", "on");
@@ -5281,7 +5281,11 @@ int main(int argc, char **argv, char **envp)
                     break;
                 }
             case QEMU_OPTION_monitor:
-                monitor_parse(optarg);
+                monitor_parse(optarg, "readline");
+                default_monitor = 0;
+                break;
+            case QEMU_OPTION_qmp:
+                monitor_parse(optarg, "control");
                 default_monitor = 0;
                 break;
             case QEMU_OPTION_mon:
@@ -5617,7 +5621,7 @@ int main(int argc, char **argv, char **envp)
             if (default_serial)
                 add_device_config(DEV_SERIAL, "stdio");
             if (default_monitor)
-                monitor_parse("stdio");
+                monitor_parse("stdio", "readline");
         }
     } else {
         if (default_serial)
@@ -5625,7 +5629,7 @@ int main(int argc, char **argv, char **envp)
         if (default_parallel)
             add_device_config(DEV_PARALLEL, "vc:80Cx24C");
         if (default_monitor)
-            monitor_parse("vc:80Cx24C");
+            monitor_parse("vc:80Cx24C", "readline");
     }
     if (default_vga)
         vga_interface_type = VGA_CIRRUS;
-- 
1.6.5.2

  parent reply	other threads:[~2009-12-08 12:12 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-08 12:11 [Qemu-devel] [FOR 0.12 PATCH v4 01/22] default devices: qdev integration Gerd Hoffmann
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 01/22] qdev: make compat stuff more generic Gerd Hoffmann
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 02/22] qdev: add command line option to set global defaults for properties Gerd Hoffmann
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 03/22] qdev: also match bus name for global properties Gerd Hoffmann
2009-12-09 16:14   ` [Qemu-devel] " Michael S. Tsirkin
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 04/22] chardev: make chardevs specified in config file work Gerd Hoffmann
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 05/22] Revert "monitor: Command-line flag to enable control mode" Gerd Hoffmann
2009-12-10  7:59   ` Markus Armbruster
2009-12-10  9:26     ` Gerd Hoffmann
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 06/22] Revert "Set default console to virtio on S390x" Gerd Hoffmann
2009-12-10  8:00   ` Markus Armbruster
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 07/22] chardev: move greeting into vc backend Gerd Hoffmann
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 08/22] vc: colorize chardev title line with blue background Gerd Hoffmann
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 09/22] default devices: core code & serial lines Gerd Hoffmann
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 10/22] default devices: parallel port Gerd Hoffmann
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 11/22] default devices: qemu monitor Gerd Hoffmann
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 12/22] zap serial_monitor_mux Gerd Hoffmann
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 13/22] default devices: vga adapter Gerd Hoffmann
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 14/22] default devices: add global cmd line option Gerd Hoffmann
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 15/22] default devices: network Gerd Hoffmann
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 16/22] default devices: drives Gerd Hoffmann
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 17/22] un-static qemu_chr_parse_compat() Gerd Hoffmann
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 18/22] rework -monitor handling, switch to QemuOpts Gerd Hoffmann
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 19/22] add new -mon switch Gerd Hoffmann
2009-12-08 12:11 ` Gerd Hoffmann [this message]
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 21/22] default devices: virtio consoles Gerd Hoffmann
2009-12-10  8:37   ` Markus Armbruster
2009-12-08 12:11 ` [Qemu-devel] [FOR 0.12 PATCH v4 22/22] Set default console to virtio on S390x Gerd Hoffmann
2009-12-10  8:36   ` Markus Armbruster
2009-12-10  9:34     ` Gerd Hoffmann
2009-12-10  9:44       ` Markus Armbruster
2009-12-08 18:21 ` [Qemu-devel] Re: [FOR 0.12 PATCH v4 01/22] default devices: qdev integration Luiz Capitulino
2009-12-10  8:39 ` [Qemu-devel] " Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1260274314-2906-21-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=agraf@suse.de \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).