qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [PATCH 09/19] monitor: Convert do_info_kvm() to QObject
Date: Wed,  9 Dec 2009 14:27:48 -0200	[thread overview]
Message-ID: <1260376078-8694-10-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1260376078-8694-1-git-send-email-lcapitulino@redhat.com>

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 monitor.c |   41 +++++++++++++++++++++++++++++++++--------
 1 files changed, 33 insertions(+), 8 deletions(-)

diff --git a/monitor.c b/monitor.c
index e7a6294..47f794d 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1783,16 +1783,40 @@ static void tlb_info(Monitor *mon)
 
 #endif
 
-static void do_info_kvm(Monitor *mon)
+static void do_info_kvm_print(Monitor *mon, const QObject *data)
 {
-#ifdef CONFIG_KVM
+    QDict *qdict;
+
+    qdict = qobject_to_qdict(data);
+
     monitor_printf(mon, "kvm support: ");
-    if (kvm_enabled())
-        monitor_printf(mon, "enabled\n");
-    else
-        monitor_printf(mon, "disabled\n");
+    if (qdict_get_bool(qdict, "present")) {
+        monitor_printf(mon, "%s\n", qdict_get_bool(qdict, "enabled") ?
+                                    "enabled" : "disabled");
+    } else {
+        monitor_printf(mon, "not compiled\n");
+    }
+}
+
+/**
+ * do_info_kvm(): Show KVM information
+ *
+ * Return a QDict with the following information:
+ *
+ * - "enabled": true if KVM support is enabled, false otherwise
+ * - "present": true if QEMU has KVM support, false otherwise
+ *
+ * Example:
+ *
+ * { "enabled": true, "present": true }
+ */
+static void do_info_kvm(Monitor *mon, QObject **ret_data)
+{
+#ifdef CONFIG_KVM
+    *ret_data = qobject_from_jsonf("{ 'enabled': %i, 'present': true }",
+                                   kvm_enabled());
 #else
-    monitor_printf(mon, "kvm support: not compiled\n");
+    *ret_data = qobject_from_jsonf("{ 'enabled': false, 'present': false }");
 #endif
 }
 
@@ -2346,7 +2370,8 @@ static const mon_cmd_t info_cmds[] = {
         .args_type  = "",
         .params     = "",
         .help       = "show KVM information",
-        .mhandler.info = do_info_kvm,
+        .user_print = do_info_kvm_print,
+        .mhandler.info_new = do_info_kvm,
     },
     {
         .name       = "numa",
-- 
1.6.6.rc1.39.g9a42

  parent reply	other threads:[~2009-12-09 16:39 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-09 16:27 [Qemu-devel] [FOR 0.12 v3 00/19]: info handlers conversions to QObject Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 01/19] Introduce qemu-objects.h header file Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 02/19] Makefile: move QObject objs to their own entry Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 03/19] QDict: Introduce qdict_get_qbool() Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 04/19] QDict: Introduce qdict_get_qlist() Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 05/19] monitor: Fix do_info_balloon() output Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 06/19] monitor: do_info_cpus(): Use QBool Luiz Capitulino
2009-12-10 10:44   ` Markus Armbruster
2009-12-10 12:00     ` Luiz Capitulino
2009-12-10 13:01     ` Anthony Liguori
2009-12-10 13:05       ` Luiz Capitulino
2009-12-10 13:08         ` Anthony Liguori
2009-12-10 13:10         ` Anthony Liguori
2009-12-10 13:22       ` Markus Armbruster
2009-12-09 16:27 ` [Qemu-devel] [PATCH 07/19] monitor: do_info_version(): Use QDict Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 08/19] monitor: Convert do_info_status() to QObject Luiz Capitulino
2009-12-09 16:27 ` Luiz Capitulino [this message]
2009-12-09 16:27 ` [Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() " Luiz Capitulino
2009-12-10 10:09   ` Markus Armbruster
2009-12-10 11:52     ` Luiz Capitulino
2009-12-10 12:56       ` Anthony Liguori
2009-12-10 15:55         ` Avi Kivity
2009-12-10 15:57           ` Avi Kivity
2009-12-10 16:03           ` Anthony Liguori
2009-12-10 16:10             ` Avi Kivity
2009-12-10 16:20               ` Anthony Liguori
2009-12-10 16:24                 ` Avi Kivity
2009-12-10 16:54                   ` Luiz Capitulino
2009-12-10 17:02                     ` Avi Kivity
2009-12-10 17:12                       ` Luiz Capitulino
2009-12-10 17:38                     ` Daniel P. Berrange
2009-12-10 17:49                       ` Luiz Capitulino
2009-12-10 18:00                         ` Daniel P. Berrange
2009-12-11 12:54                           ` Luiz Capitulino
2009-12-11 13:14                             ` Anthony Liguori
2009-12-11 13:20                       ` Anthony Liguori
2009-12-11 19:46                         ` Daniel P. Berrange
2009-12-11 13:18                     ` Anthony Liguori
2009-12-11 13:27                       ` Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 11/19] monitor: Convert do_info_hpet() " Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 12/19] monitor: Convert do_info_uuid() " Luiz Capitulino
2009-12-10 10:14   ` Markus Armbruster
2009-12-09 16:27 ` [Qemu-devel] [PATCH 13/19] monitor: Convert do_info_mice() " Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 14/19] migration: Convert do_info_migrate() " Luiz Capitulino
2009-12-10 10:19   ` Markus Armbruster
2009-12-09 16:27 ` [Qemu-devel] [PATCH 15/19] block: Convert bdrv_info() " Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 16/19] block: Convert bdrv_info_stats() " Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 17/19] char: Convert qemu_chr_info() " Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 18/19] PCI: Convert pci_device_hot_add() " Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 19/19] VNC: Convert do_info_vnc() " Luiz Capitulino
2009-12-10 10:34   ` Markus Armbruster
2009-12-10 11:56     ` Luiz Capitulino
2009-12-10 12:12       ` Daniel P. Berrange
2009-12-10 13:00     ` Anthony Liguori
2009-12-10 10:49 ` [Qemu-devel] [FOR 0.12 v3 00/19]: info handlers conversions " Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1260376078-8694-10-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).