From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKRsu-0004kF-Ba for qemu-devel@nongnu.org; Wed, 29 Jul 2015 09:59:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKRso-0008BZ-GU for qemu-devel@nongnu.org; Wed, 29 Jul 2015 09:59:04 -0400 Received: from mx6-phx2.redhat.com ([209.132.183.39]:38444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKRso-0008Aa-8T for qemu-devel@nongnu.org; Wed, 29 Jul 2015 09:58:58 -0400 Date: Wed, 29 Jul 2015 09:58:35 -0400 (EDT) From: Thomas Huth Message-ID: <1260504275.383697.1438178315062.JavaMail.zimbra@redhat.com> In-Reply-To: <55B8DA0A.2040009@cn.fujitsu.com> References: <1438167116-29270-1-git-send-email-yanghy@cn.fujitsu.com> <1438167116-29270-3-git-send-email-yanghy@cn.fujitsu.com> <1012207755.363443.1438176811477.JavaMail.zimbra@redhat.com> <55B8DA0A.2040009@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/12] init/cleanup of netfilter object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yang Hongyang Cc: zhang zhanghailiang , jasowang@redhat.com, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, stefanha@redhat.com On Wednesday, July 29, 2015 3:50:02 PM, "Yang Hongyang" wrote: > > On 07/29/2015 09:33 PM, Thomas Huth wrote: > > On Wednesday, July 29, 2015 12:51:46 PM, > > "Yang Hongyang" wrote: > >> > >> This is mostly the same with init/cleanup of netdev object. > >> > >> Signed-off-by: Yang Hongyang > >> --- > >> include/net/filter.h | 21 ++++++++ > >> include/qemu/typedefs.h | 1 + > >> net/filter.c | 131 > >> ++++++++++++++++++++++++++++++++++++++++++++++++ > >> qapi-schema.json | 30 +++++++++++ > >> 4 files changed, 183 insertions(+) > >> > > [...] > >> diff --git a/net/filter.c b/net/filter.c > >> index 4e40f08..e6fdc26 100644 > >> --- a/net/filter.c > >> +++ b/net/filter.c > >> @@ -6,10 +6,141 @@ > >> */ > >> > >> #include "qemu-common.h" > >> +#include "qapi-visit.h" > >> +#include "qapi/qmp/qerror.h" > >> +#include "qemu/error-report.h" > >> +#include "qapi-visit.h" > >> +#include "qapi/opts-visitor.h" > >> +#include "qapi/dealloc-visitor.h" > >> +#include "qemu/config-file.h" > >> + > >> #include "net/filter.h" > >> +#include "net/net.h" > >> + > >> +static QTAILQ_HEAD(, NetFilterState) net_filters; > >> + > >> +NetFilterState *qemu_new_net_filter(NetFilterInfo *info, > >> + NetClientState *netdev, > >> + const char *model, > >> + const char *name) > >> +{ > >> + NetFilterState *nf; > >> + > >> + assert(info->size >= sizeof(NetFilterState)); > >> + > >> + nf = g_malloc0(info->size); > >> + nf->info = info; > >> + nf->model = g_strdup(model); > >> + nf->name = g_strdup(name); > >> + nf->netdev = netdev; > >> + QTAILQ_INSERT_TAIL(&net_filters, nf, next); > >> + /* TODO: attach netfilter to netdev */ > >> + > >> + return nf; > >> +} > >> + > >> +static __attribute__((unused)) void > >> qemu_cleanup_net_filter(NetFilterState > >> *nf) > > > > Maybe rather add this function in the patch you really need it? Then you > > could > > avoid the ugly attribute-unused here. > > It will be removed in the next patch. I put cleanup here in order to pair > with the new function, and could be easy to review... You could also use another trick: Use "static inline" instead of "static __attribute__((unused))" ... then GCC also does not complain about unused static functions! Thomas