From: Stefan Weil <weil@mail.berlios.de>
To: QEMU Developers <qemu-devel@nongnu.org>,
aliguori@us.ibm.com, mst@redhat.com
Subject: [Qemu-devel] [PATCH] eepro100: Better documentation for temporary data
Date: Mon, 14 Dec 2009 10:25:34 +0100 [thread overview]
Message-ID: <1260782734-11399-1-git-send-email-weil@mail.berlios.de> (raw)
In-Reply-To: <20091213213637.GA25879@redhat.com>
Michael S. Tsirkin suggested more documentation for
two temporary status values. Well, here it is.
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
hw/eepro100.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/eepro100.c b/hw/eepro100.c
index 22e5bed..5a77409 100644
--- a/hw/eepro100.c
+++ b/hw/eepro100.c
@@ -213,9 +213,10 @@ typedef struct {
uint32_t ru_offset; /* RU address offset */
uint32_t statsaddr; /* pointer to eepro100_stats_t */
- /* Temporary data. */
- eepro100_tx_t tx;
- uint32_t cb_address;
+ /* Temporary status information (no need to save these values),
+ * used while processing CU commands. */
+ eepro100_tx_t tx; /* transmit buffer descriptor */
+ uint32_t cb_address; /* = cu_base + cu_offset */
/* Statistical counters. Also used for wake-up packet (i82559). */
eepro100_stats_t statistics;
--
1.6.5
next prev parent reply other threads:[~2009-12-14 9:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 20:54 [Qemu-devel] [PATCH] eepro100: Restructure code (new function tx_command) Stefan Weil
2009-11-30 9:30 ` [Qemu-devel] " Michael S. Tsirkin
2009-11-30 17:05 ` Stefan Weil
2009-11-30 20:39 ` Michael S. Tsirkin
2009-12-12 19:45 ` Stefan Weil
2009-12-13 8:18 ` Michael S. Tsirkin
2009-12-13 20:59 ` Stefan Weil
2009-12-13 21:36 ` Michael S. Tsirkin
2009-12-14 9:25 ` Stefan Weil [this message]
2009-12-15 15:49 ` [Qemu-devel] Re: [PATCH] eepro100: Better documentation for temporary data Michael S. Tsirkin
2009-12-12 14:03 ` [Qemu-devel] Re: [PATCH] eepro100: Restructure code (new function tx_command) Stefan Weil
2009-12-12 14:05 ` [Qemu-devel] " Stefan Weil
2009-12-12 15:21 ` [Qemu-devel] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260782734-11399-1-git-send-email-weil@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=aliguori@us.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).