qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Isaku Yamahata <yamahata@valinux.co.jp>
To: qemu-devel@nongnu.org, mst@redhat.com
Cc: yamahata@valinux.co.jp
Subject: [Qemu-devel] [PATCH 07/11] gt64xxx: remove gt64120_{read, write}_config().
Date: Mon, 14 Dec 2009 21:48:22 +0900	[thread overview]
Message-ID: <1260794906-30168-8-git-send-email-yamahata@valinux.co.jp> (raw)
In-Reply-To: <1260794906-30168-1-git-send-email-yamahata@valinux.co.jp>

They call only pci_default_{read, write}_config().
So they aren't necessary.

Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
 hw/gt64xxx.c |   13 +------------
 1 files changed, 1 insertions(+), 12 deletions(-)

diff --git a/hw/gt64xxx.c b/hw/gt64xxx.c
index fb7f5bd..c8034e2 100644
--- a/hw/gt64xxx.c
+++ b/hw/gt64xxx.c
@@ -1082,17 +1082,6 @@ static void gt64120_reset(void *opaque)
     gt64120_pci_mapping(s);
 }
 
-static uint32_t gt64120_read_config(PCIDevice *d, uint32_t address, int len)
-{
-    return pci_default_read_config(d, address, len);
-}
-
-static void gt64120_write_config(PCIDevice *d, uint32_t address, uint32_t val,
-                                 int len)
-{
-    pci_default_write_config(d, address, val, len);
-}
-
 static void gt64120_save(QEMUFile* f, void *opaque)
 {
     PCIDevice *d = opaque;
@@ -1125,7 +1114,7 @@ PCIBus *pci_gt64120_init(qemu_irq *pic)
                                    pic, 144, 4);
     s->ISD_handle = cpu_register_io_memory(gt64120_read, gt64120_write, s);
     d = pci_register_device(s->pci->bus, "GT64120 PCI Bus", sizeof(PCIDevice),
-                            0, gt64120_read_config, gt64120_write_config);
+                            0, NULL, NULL);
 
     /* FIXME: Malta specific hw assumptions ahead */
 
-- 
1.6.5.4

  parent reply	other threads:[~2009-12-14 12:48 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-14 12:48 [Qemu-devel] [PATCH 00/11] various pci clean ups Isaku Yamahata
2009-12-14 12:48 ` [Qemu-devel] [PATCH 01/11] pci: remove PCIBus::config_reg Isaku Yamahata
2009-12-14 13:51   ` [Qemu-devel] " Michael S. Tsirkin
2009-12-14 12:48 ` [Qemu-devel] [PATCH 02/11] pci: clean up pci_bar_address() Isaku Yamahata
2009-12-14 13:36   ` [Qemu-devel] " Michael S. Tsirkin
2009-12-14 12:48 ` [Qemu-devel] [PATCH 03/11] pci: s/PCI_SUBVENDOR_ID/PCI_SUBSYSTEM_VENDOR_ID/g Isaku Yamahata
2009-12-14 13:36   ` [Qemu-devel] " Michael S. Tsirkin
2009-12-14 12:48 ` [Qemu-devel] [PATCH 04/11] pci: remove PCI_REVISION and PCI_SUBDEVICE_ID Isaku Yamahata
2009-12-14 13:53   ` [Qemu-devel] " Michael S. Tsirkin
2009-12-14 12:48 ` [Qemu-devel] [PATCH 05/11] pci: import Linux pci_regs.h Isaku Yamahata
2009-12-14 12:48 ` [Qemu-devel] [PATCH 06/11] pci: use pci_regs.h Isaku Yamahata
2009-12-14 13:37   ` [Qemu-devel] " Michael S. Tsirkin
2009-12-14 12:48 ` Isaku Yamahata [this message]
2009-12-14 13:51   ` [Qemu-devel] Re: [PATCH 07/11] gt64xxx: remove gt64120_{read, write}_config() Michael S. Tsirkin
2009-12-14 12:48 ` [Qemu-devel] [PATCH 08/11] acpi: use range helper function Isaku Yamahata
2009-12-14 13:37   ` [Qemu-devel] " Michael S. Tsirkin
2009-12-14 12:48 ` [Qemu-devel] [PATCH 09/11] piix_pci: define symbolic value for PAM0, PAM6 and SMRAM Isaku Yamahata
2009-12-14 13:49   ` [Qemu-devel] " Michael S. Tsirkin
2009-12-14 12:48 ` [Qemu-devel] [PATCH 10/11] piix_pci: use range helper function Isaku Yamahata
2009-12-14 13:50   ` [Qemu-devel] " Michael S. Tsirkin
2009-12-14 12:48 ` [Qemu-devel] [PATCH 11/11] msix: " Isaku Yamahata
2009-12-14 13:25   ` [Qemu-devel] " Michael S. Tsirkin
2009-12-14 13:54 ` [Qemu-devel] Re: [PATCH 00/11] various pci clean ups Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1260794906-30168-8-git-send-email-yamahata@valinux.co.jp \
    --to=yamahata@valinux.co.jp \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).