From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NKHvR-0002GM-0X for qemu-devel@nongnu.org; Mon, 14 Dec 2009 15:53:49 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NKHvM-0002CI-6T for qemu-devel@nongnu.org; Mon, 14 Dec 2009 15:53:48 -0500 Received: from [199.232.76.173] (port=39713 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NKHvL-0002CA-WE for qemu-devel@nongnu.org; Mon, 14 Dec 2009 15:53:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58216) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NKHvL-0002eU-9v for qemu-devel@nongnu.org; Mon, 14 Dec 2009 15:53:43 -0500 From: Luiz Capitulino Date: Mon, 14 Dec 2009 18:53:20 -0200 Message-Id: <1260824004-2941-2-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1260824004-2941-1-git-send-email-lcapitulino@redhat.com> References: <1260824004-2941-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 1/5] QDict: Fix size update List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com Key replacement should not update the dictionary's size. This commit also adds a test for the bug. Signed-off-by: Luiz Capitulino --- check-qdict.c | 2 ++ qdict.c | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/check-qdict.c b/check-qdict.c index c37d448..f2b4826 100644 --- a/check-qdict.c +++ b/check-qdict.c @@ -205,6 +205,8 @@ START_TEST(qdict_put_exists_test) value = qdict_get_int(tests_dict, key); fail_unless(value == 2); + + fail_unless(qdict_size(tests_dict) == 1); } END_TEST diff --git a/qdict.c b/qdict.c index ef73265..ba8eef0 100644 --- a/qdict.c +++ b/qdict.c @@ -122,9 +122,8 @@ void qdict_put_obj(QDict *qdict, const char *key, QObject *value) /* allocate a new entry */ entry = alloc_entry(key, value); QLIST_INSERT_HEAD(&qdict->table[hash], entry, next); + qdict->size++; } - - qdict->size++; } /** -- 1.6.6.rc2.5.g49666