From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [PATCH 2/5] monitor: Use 'device' in eject
Date: Mon, 14 Dec 2009 18:53:21 -0200 [thread overview]
Message-ID: <1260824004-2941-3-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1260824004-2941-1-git-send-email-lcapitulino@redhat.com>
Monitor's eject command uses 'filename' for the device name
argument, but 'device' is a better name.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
monitor.c | 2 +-
qemu-monitor.hx | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/monitor.c b/monitor.c
index d97d529..d5041dc 100644
--- a/monitor.c
+++ b/monitor.c
@@ -864,7 +864,7 @@ static void do_eject(Monitor *mon, const QDict *qdict, QObject **ret_data)
{
BlockDriverState *bs;
int force = qdict_get_int(qdict, "force");
- const char *filename = qdict_get_str(qdict, "filename");
+ const char *filename = qdict_get_str(qdict, "device");
bs = bdrv_find(filename);
if (!bs) {
diff --git a/qemu-monitor.hx b/qemu-monitor.hx
index c788c73..338e30e 100644
--- a/qemu-monitor.hx
+++ b/qemu-monitor.hx
@@ -130,7 +130,7 @@ ETEXI
{
.name = "eject",
- .args_type = "force:-f,filename:B",
+ .args_type = "force:-f,device:B",
.params = "[-f] device",
.help = "eject a removable medium (use -f to force it)",
.user_print = monitor_user_noop,
--
1.6.6.rc2.5.g49666
next prev parent reply other threads:[~2009-12-14 20:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-14 20:53 [Qemu-devel] [FOR 0.12 0/5]: Misc QMP related fixes Luiz Capitulino
2009-12-14 20:53 ` [Qemu-devel] [PATCH 1/5] QDict: Fix size update Luiz Capitulino
2009-12-14 20:53 ` Luiz Capitulino [this message]
2009-12-14 20:53 ` [Qemu-devel] [PATCH 3/5] monitor: do_balloon(): Check for errors Luiz Capitulino
2009-12-14 20:53 ` [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP Luiz Capitulino
2009-12-15 9:50 ` Markus Armbruster
2009-12-15 9:54 ` Markus Armbruster
2009-12-15 12:08 ` Luiz Capitulino
2009-12-15 14:03 ` Markus Armbruster
2009-12-15 14:17 ` [Qemu-devel] " Jan Kiszka
2009-12-14 20:53 ` [Qemu-devel] [PATCH 5/5] monitor: Catch printing to non-existent monitor Luiz Capitulino
2009-12-15 9:42 ` Markus Armbruster
2009-12-15 12:02 ` Luiz Capitulino
2009-12-15 13:56 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260824004-2941-3-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).