qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Isaku Yamahata <yamahata@valinux.co.jp>
To: qemu-devel@nongnu.org, mst@redhat.com
Cc: yamahata@valinux.co.jp
Subject: [Qemu-devel] [PATCH V2 09/10] piix_pci: use range helper function
Date: Tue, 15 Dec 2009 20:26:06 +0900	[thread overview]
Message-ID: <1260876367-28197-10-git-send-email-yamahata@valinux.co.jp> (raw)
In-Reply-To: <1260876367-28197-1-git-send-email-yamahata@valinux.co.jp>

use range helper function in i440fx_write_config().

Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
 hw/piix_pci.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index 0dae6f9..384d31c 100644
--- a/hw/piix_pci.c
+++ b/hw/piix_pci.c
@@ -137,10 +137,10 @@ static void i440fx_write_config(PCIDevice *dev,
 
     /* XXX: implement SMRAM.D_LOCK */
     pci_default_write_config(dev, address, val, len);
-    if ((address >= I440FX_PAM &&
-         address <= I440FX_PAM + I440FX_PAM_SIZE - 1) ||
-        address == I440FX_SMRAM)
+    if (ranges_overlap(address, len, I440FX_PAM, I440FX_PAM_SIZE) ||
+        range_covers_byte(address, len, I440FX_SMRAM)) {
         i440fx_update_memory_mappings(d);
+    }
 }
 
 static int i440fx_load_old(QEMUFile* f, void *opaque, int version_id)
-- 
1.6.5.4

  parent reply	other threads:[~2009-12-15 11:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-15 11:25 [Qemu-devel] [PATCH V2 00/10] various pci clean ups Isaku Yamahata
2009-12-15 11:25 ` [Qemu-devel] [PATCH V2 01/10] pci: remove PCIBus::config_reg Isaku Yamahata
2009-12-15 11:25 ` [Qemu-devel] [PATCH V2 02/10] pci: s/PCI_SUBVENDOR_ID/PCI_SUBSYSTEM_VENDOR_ID/g Isaku Yamahata
2009-12-15 11:26 ` [Qemu-devel] [PATCH V2 03/10] pci: import Linux pci_regs.h Isaku Yamahata
2009-12-15 11:26 ` [Qemu-devel] [PATCH V2 04/10] pci: use pci_regs.h Isaku Yamahata
2009-12-15 11:26 ` [Qemu-devel] [PATCH V2 05/10] gt64xxx: remove gt64120_{read, write}_config() Isaku Yamahata
2009-12-15 11:26 ` [Qemu-devel] [PATCH V2 06/10] acpi: use range helper function Isaku Yamahata
2009-12-15 11:26 ` [Qemu-devel] [PATCH V2 07/10] msix: " Isaku Yamahata
2009-12-15 11:26 ` [Qemu-devel] [PATCH V2 08/10] piix_pci: define symbolic value for PAM0, PAM6 and SMRAM Isaku Yamahata
2009-12-15 11:26 ` Isaku Yamahata [this message]
2009-12-15 11:26 ` [Qemu-devel] [PATCH V2 10/10] piix_pci: add link to i440fx data sheet Isaku Yamahata
2009-12-15 11:41 ` [Qemu-devel] Re: [PATCH V2 00/10] various pci clean ups Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1260876367-28197-10-git-send-email-yamahata@valinux.co.jp \
    --to=yamahata@valinux.co.jp \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).