[Qemu-devel] [PATCH] mips: No MIPS16 support for 4Kc, 4KEc cores

qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed

* [Qemu-devel] [PATCH] mips: No MIPS16 support for 4Kc, 4KEc cores
@ 2009-12-15 13:03 Stefan Weil
  2009-12-15 13:22 ` Nathan Froyd
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2009-12-15 13:03 UTC (permalink / raw)
  To: Nathan Froyd, Aurelien Jarno, QEMU Developers

Fix regression introduced by d19954f46dfc262612c30e9534e660e953049487.

4Kc and 4KEc don't support MIPS16.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 target-mips/translate_init.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/target-mips/translate_init.c b/target-mips/translate_init.c
index 11bc47c..b710979 100644
--- a/target-mips/translate_init.c
+++ b/target-mips/translate_init.c
@@ -105,7 +105,7 @@ static const mips_def_t mips_defs[] =
         .CP0_Config1 = MIPS_CONFIG1 | (15 << CP0C1_MMU) |
                        (0 << CP0C1_IS) | (3 << CP0C1_IL) | (1 << CP0C1_IA) |
                        (0 << CP0C1_DS) | (3 << CP0C1_DL) | (1 << CP0C1_DA) |
-                       (1 << CP0C1_CA),
+                       (0 << CP0C1_CA),
         .CP0_Config2 = MIPS_CONFIG2,
         .CP0_Config3 = MIPS_CONFIG3,
         .CP0_LLAddr_rw_bitmask = 0,
@@ -147,7 +147,7 @@ static const mips_def_t mips_defs[] =
         .CP0_Config1 = MIPS_CONFIG1 | (15 << CP0C1_MMU) |
                        (0 << CP0C1_IS) | (3 << CP0C1_IL) | (1 << CP0C1_IA) |
                        (0 << CP0C1_DS) | (3 << CP0C1_DL) | (1 << CP0C1_DA) |
-                       (1 << CP0C1_CA),
+                       (0 << CP0C1_CA),
         .CP0_Config2 = MIPS_CONFIG2,
         .CP0_Config3 = MIPS_CONFIG3,
         .CP0_LLAddr_rw_bitmask = 0,
@@ -188,7 +188,7 @@ static const mips_def_t mips_defs[] =
         .CP0_Config1 = MIPS_CONFIG1 | (15 << CP0C1_MMU) |
                        (0 << CP0C1_IS) | (3 << CP0C1_IL) | (1 << CP0C1_IA) |
                        (0 << CP0C1_DS) | (3 << CP0C1_DL) | (1 << CP0C1_DA) |
-                       (1 << CP0C1_CA),
+                       (0 << CP0C1_CA),
         .CP0_Config2 = MIPS_CONFIG2,
         .CP0_Config3 = MIPS_CONFIG3 | (0 << CP0C3_VInt),
         .CP0_LLAddr_rw_bitmask = 0,
-- 
1.6.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] mips: No MIPS16 support for 4Kc, 4KEc cores
  2009-12-15 13:03 [Qemu-devel] [PATCH] mips: No MIPS16 support for 4Kc, 4KEc cores Stefan Weil
@ 2009-12-15 13:22 ` Nathan Froyd
  0 siblings, 0 replies; 2+ messages in thread
From: Nathan Froyd @ 2009-12-15 13:22 UTC (permalink / raw)
  To: Stefan Weil; +Cc: QEMU Developers, Aurelien Jarno

On Tue, Dec 15, 2009 at 02:03:03PM +0100, Stefan Weil wrote:
> Fix regression introduced by d19954f46dfc262612c30e9534e660e953049487.
> 
> 4Kc and 4KEc don't support MIPS16.

Nice catch.  Can you please also remove ASE_MIPS16 from .insn_flags for
those same CPUs, then?

Thanks,
-Nathan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-12-15 13:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-15 13:03 [Qemu-devel] [PATCH] mips: No MIPS16 support for 4Kc, 4KEc cores Stefan Weil
2009-12-15 13:22 ` Nathan Froyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).