From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Juan Quintela <quintela@redhat.com>
Subject: [Qemu-devel] [PATCH] user_only: compile everything with -fpie
Date: Wed, 16 Dec 2009 16:20:34 +0200 [thread overview]
Message-ID: <1260973234-12601-1-git-send-email-kirill@shutemov.name> (raw)
We really need compile _all_ sources for user target with -fpie when
use --enable-user-pie.
It's regression introduced by commit add16157d72454.
Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
Cc: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
Makefile.user | 7 ++++++-
configure | 3 +++
2 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/Makefile.user b/Makefile.user
index 907e74b..9e4f040 100644
--- a/Makefile.user
+++ b/Makefile.user
@@ -2,10 +2,15 @@
include ../config-host.mak
include $(SRC_PATH)/rules.mak
+include config.mak
.PHONY: all
-VPATH=$(SRC_PATH)
+# Do not take %.o from $(SRC_PATH), only %.c and %.h
+# All %.o for user targets should be built with -fpie, when
+# configured with --enable-user-pie, so we don't want to
+# take %.o from $(SRC_PATH), since they built without -fpie
+vpath %.c %.h $(SRC_PATH)
QEMU_CFLAGS+=-I..
diff --git a/configure b/configure
index 273b6b7..5f463b0 100755
--- a/configure
+++ b/configure
@@ -2652,3 +2652,6 @@ d=libuser
mkdir -p $d
rm -f $d/Makefile
ln -s $source_path/Makefile.user $d/Makefile
+if test "$static" = "no" -a "$user_pie" = "yes" ; then
+ echo "QEMU_CFLAGS+=-fpie" > $d/config.mak
+fi
--
1.6.5.6
next reply other threads:[~2009-12-16 14:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 14:20 Kirill A. Shutemov [this message]
2009-12-19 0:26 ` [Qemu-devel] Re: [PATCH] user_only: compile everything with -fpie Kirill A. Shutemov
2009-12-19 0:44 ` Juan Quintela
2009-12-19 10:08 ` Blue Swirl
2009-12-19 13:05 ` Aurelien Jarno
2009-12-19 15:19 ` Blue Swirl
2009-12-19 15:34 ` Aurelien Jarno
2009-12-19 15:48 ` Blue Swirl
2009-12-19 16:03 ` Aurelien Jarno
2009-12-19 15:58 ` Aurelien Jarno
2009-12-19 16:00 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260973234-12601-1-git-send-email-kirill@shutemov.name \
--to=kirill@shutemov.name \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).