From: Alexander Graf <agraf@suse.de>
To: qemu-devel@nongnu.org
Cc: aurelien@aurel32.net
Subject: [Qemu-devel] [PATCH 3/3] S390: Don't tell guest we're updating config space
Date: Thu, 17 Dec 2009 13:06:09 +0100 [thread overview]
Message-ID: <1261051569-7503-4-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1261051569-7503-1-git-send-email-agraf@suse.de>
Currently we always set the "config space changed" bit to 1 when triggering
any virtio interrupt. While that worked in 2.6.27, newer kernels interpret
that value as "only the config space changed and nothing else happened".
Since we usually trigger interrupts to tell the guest that something did
happen, we just not tell it the config space changed for now until we
implement the correct callback for that.
Signed-off-by: Alexander Graf <agraf@suse.de>
---
hw/s390-virtio-bus.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/s390-virtio-bus.c b/hw/s390-virtio-bus.c
index 493e4da..dc154ed 100644
--- a/hw/s390-virtio-bus.c
+++ b/hw/s390-virtio-bus.c
@@ -307,7 +307,7 @@ static void virtio_s390_notify(void *opaque, uint16_t vector)
uint64_t token = s390_virtio_device_vq_token(dev, vector);
/* XXX kvm dependency! */
- kvm_s390_virtio_irq(s390_cpu_addr2state(0), 1, token);
+ kvm_s390_virtio_irq(s390_cpu_addr2state(0), 0, token);
}
/**************** S390 Virtio Bus Device Descriptions *******************/
--
1.6.0.2
prev parent reply other threads:[~2009-12-17 12:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-17 12:06 [Qemu-devel] [PATCH 0/3] (0.12) S390 patches Alexander Graf
2009-12-17 12:06 ` [Qemu-devel] [PATCH 1/3] S390: Loop through virtio console devices Alexander Graf
2009-12-17 12:06 ` [Qemu-devel] [PATCH 2/3] add default virtcon initialization Alexander Graf
2009-12-17 12:06 ` Alexander Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261051569-7503-4-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).