From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NLehk-0000yc-Ni for qemu-devel@nongnu.org; Fri, 18 Dec 2009 10:25:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NLehg-0000ta-5O for qemu-devel@nongnu.org; Fri, 18 Dec 2009 10:25:20 -0500 Received: from [199.232.76.173] (port=57992 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NLehf-0000tX-VY for qemu-devel@nongnu.org; Fri, 18 Dec 2009 10:25:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33071) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NLehf-0006G2-K4 for qemu-devel@nongnu.org; Fri, 18 Dec 2009 10:25:15 -0500 From: Luiz Capitulino Date: Fri, 18 Dec 2009 13:24:59 -0200 Message-Id: <1261149905-7622-2-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1261149905-7622-1-git-send-email-lcapitulino@redhat.com> References: <1261149905-7622-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 1/7] QMP: Only handle converted commands List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com Looks like I dropped this check when addressing the 'query-' commands request. QMP should only handle converted commands, obviously. Reported-by: Markus Armbruster Signed-off-by: Luiz Capitulino --- monitor.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index ebd0282..1455258 100644 --- a/monitor.c +++ b/monitor.c @@ -4070,7 +4070,7 @@ static void handle_qmp_command(JSONMessageParser *parser, QList *tokens) qobject_from_jsonf("{ 'item': %s }", info_item)); } else { cmd = monitor_find_command(cmd_name); - if (!cmd) { + if (!cmd || !monitor_handler_ported(cmd)) { qemu_error_new(QERR_COMMAND_NOT_FOUND, cmd_name); goto err_input; } -- 1.6.6.rc3