From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NLehp-00012O-7v for qemu-devel@nongnu.org; Fri, 18 Dec 2009 10:25:25 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NLehi-0000v9-Fl for qemu-devel@nongnu.org; Fri, 18 Dec 2009 10:25:22 -0500 Received: from [199.232.76.173] (port=57994 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NLehi-0000us-A4 for qemu-devel@nongnu.org; Fri, 18 Dec 2009 10:25:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32734) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NLehh-0006GQ-Uy for qemu-devel@nongnu.org; Fri, 18 Dec 2009 10:25:18 -0500 From: Luiz Capitulino Date: Fri, 18 Dec 2009 13:25:00 -0200 Message-Id: <1261149905-7622-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1261149905-7622-1-git-send-email-lcapitulino@redhat.com> References: <1261149905-7622-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 2/7] QMP: Return an empty dict by default List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com Currently, when a regular command doesn't have any data to output, QMP will emit: { "return": "OK" } Returning an empty dict is better though, because dicts can support some protocol changes in a compatible way. So, with this commit we will return: { "return": {} } Signed-off-by: Luiz Capitulino --- monitor.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index 1455258..d238660 100644 --- a/monitor.c +++ b/monitor.c @@ -286,7 +286,8 @@ static void monitor_protocol_emitter(Monitor *mon, QObject *data) qobject_incref(data); qdict_put_obj(qmp, "return", data); } else { - qdict_put(qmp, "return", qstring_from_str("OK")); + /* return an empty QDict by default */ + qdict_put(qmp, "return", qdict_new()); } } else { /* error response */ -- 1.6.6.rc3