qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [PATCH 7/7] monitor: do_balloon(): Use 'M' argument type
Date: Fri, 18 Dec 2009 13:25:05 -0200	[thread overview]
Message-ID: <1261149905-7622-8-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1261149905-7622-1-git-send-email-lcapitulino@redhat.com>

This makes do_balloon() accept megabyte values from the user
Monitor while accepting byte values for QMP.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 monitor.c       |    3 +--
 qemu-monitor.hx |    2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/monitor.c b/monitor.c
index f779680..6f5b90d 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2083,8 +2083,7 @@ static void do_balloon(Monitor *mon, const QDict *qdict, QObject **ret_data)
 {
     if (balloon_get_value()) {
         /* ballooning is active */
-        ram_addr_t value = qdict_get_int(qdict, "value");
-        qemu_balloon(value << 20);
+        qemu_balloon(qdict_get_int(qdict, "value"));
     }
 }
 
diff --git a/qemu-monitor.hx b/qemu-monitor.hx
index 338e30e..aac0f3e 100644
--- a/qemu-monitor.hx
+++ b/qemu-monitor.hx
@@ -887,7 +887,7 @@ ETEXI
 
     {
         .name       = "balloon",
-        .args_type  = "value:i",
+        .args_type  = "value:M",
         .params     = "target",
         .help       = "request VM to change it's memory allocation (in MB)",
         .user_print = monitor_user_noop,
-- 
1.6.6.rc3

  parent reply	other threads:[~2009-12-18 15:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-18 15:24 [Qemu-devel] [FOR 0.12 0/7]: More QMP related fixes Luiz Capitulino
2009-12-18 15:24 ` [Qemu-devel] [PATCH 1/7] QMP: Only handle converted commands Luiz Capitulino
2009-12-18 15:25 ` [Qemu-devel] [PATCH 2/7] QMP: Return an empty dict by default Luiz Capitulino
2009-12-18 15:25 ` [Qemu-devel] [PATCH 3/7] QMP: Assure that returned data is a QDict Luiz Capitulino
2009-12-21 19:21   ` Nathan Baum
2009-12-22  3:06     ` Luiz Capitulino
2009-12-18 15:25 ` [Qemu-devel] [PATCH 4/7] QMP: Update README file Luiz Capitulino
2009-12-18 15:25 ` [Qemu-devel] [PATCH 5/7] QMP: Update spec file Luiz Capitulino
2009-12-18 17:20   ` Markus Armbruster
2009-12-18 17:44     ` Anthony Liguori
2009-12-18 17:48       ` Luiz Capitulino
2009-12-18 18:06       ` Markus Armbruster
2009-12-18 18:08         ` Luiz Capitulino
2009-12-18 17:55     ` Luiz Capitulino
2009-12-18 18:38       ` Markus Armbruster
2009-12-18 15:25 ` [Qemu-devel] [PATCH 6/7] monitor: Introduce 'M' argument type Luiz Capitulino
2009-12-18 15:25 ` Luiz Capitulino [this message]
2009-12-18 17:25 ` [Qemu-devel] [FOR 0.12 0/7]: More QMP related fixes Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1261149905-7622-8-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).