From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: qemu-devel@nongnu.org
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>
Subject: [Qemu-devel] [PATCH 16/18] hw/pc.c: fix warnings with _FORTIFY_SOURCE
Date: Sun, 20 Dec 2009 03:39:25 +0200 [thread overview]
Message-ID: <1261273167-3240-16-git-send-email-kirill@shutemov.name> (raw)
In-Reply-To: <1261273167-3240-15-git-send-email-kirill@shutemov.name>
CC i386-softmmu/pc.o
cc1: warnings being treated as errors
/usr/src/RPM/BUILD/qemu-0.11.92/hw/pc.c: In function 'load_multiboot':
/usr/src/RPM/BUILD/qemu-0.11.92/hw/pc.c:614: error: ignoring return value of 'fread', declared with attribute warn_unused_result
/usr/src/RPM/BUILD/qemu-0.11.92/hw/pc.c: In function 'load_linux':
/usr/src/RPM/BUILD/qemu-0.11.92/hw/pc.c:888: error: ignoring return value of 'fread', declared with attribute warn_unused_result
/usr/src/RPM/BUILD/qemu-0.11.92/hw/pc.c:889: error: ignoring return value of 'fread', declared with attribute warn_unused_result
make[1]: *** [pc.o] Error 1
Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
---
hw/pc.c | 15 ++++++++++++---
1 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index db7d58e..83f8dd0 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -613,7 +613,10 @@ static int load_multiboot(void *fw_cfg,
mb_kernel_data = qemu_malloc(mb_kernel_size);
fseek(f, mb_kernel_text_offset, SEEK_SET);
- fread(mb_kernel_data, 1, mb_kernel_size, f);
+ if (fread(mb_kernel_data, 1, mb_kernel_size, f) != mb_kernel_size) {
+ fprintf(stderr, "fread() failed\n");
+ exit(1);
+ }
fclose(f);
}
@@ -887,8 +890,14 @@ static void load_linux(void *fw_cfg,
setup = qemu_malloc(setup_size);
kernel = qemu_malloc(kernel_size);
fseek(f, 0, SEEK_SET);
- fread(setup, 1, setup_size, f);
- fread(kernel, 1, kernel_size, f);
+ if (fread(setup, 1, setup_size, f) != setup_size) {
+ fprintf(stderr, "fread() failed\n");
+ exit(1);
+ }
+ if (fread(kernel, 1, kernel_size, f) != kernel_size) {
+ fprintf(stderr, "fread() failed\n");
+ exit(1);
+ }
fclose(f);
memcpy(setup, header, MIN(sizeof(header), setup_size));
--
1.6.5.6
next prev parent reply other threads:[~2009-12-20 1:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-20 1:39 [Qemu-devel] [PATCH 01/18] Do not disable _FORTIFY_SOURCE Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 02/18] block.c: fix warning with _FORTIFY_SOURCE Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 03/18] posix-aio-compat.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 04/18] block/cow.c: fix warnings " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 05/18] block/qcow.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 06/18] block/vmdk.o: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 07/18] block/bochs.c: fix warning " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 08/18] block/vvfat.c: fix warnings " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 09/18] block/qcow2.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 10/18] net/slirp.c: fix warning " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 11/18] usb-linux.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 12/18] savevm.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 13/18] slirp/misc.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 14/18] vl.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 15/18] monitor.c: fix warnings " Kirill A. Shutemov
2009-12-20 1:39 ` Kirill A. Shutemov [this message]
2009-12-20 1:39 ` [Qemu-devel] [PATCH 17/18] path.c fix warning " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 18/18] linux-user/mmap.c: fix warnings " Kirill A. Shutemov
2009-12-22 20:49 ` [Qemu-devel] [PATCH 17/18] path.c fix warning " Blue Swirl
2009-12-22 20:43 ` [Qemu-devel] [PATCH 16/18] hw/pc.c: fix warnings " Blue Swirl
2009-12-22 21:12 ` [Qemu-devel] [PATCH 14/18] vl.c: fix warning " Blue Swirl
2009-12-22 19:21 ` [Qemu-devel] [PATCH 12/18] savevm.c: " Blue Swirl
2009-12-22 19:03 ` [Qemu-devel] [PATCH 11/18] usb-linux.c: " Blue Swirl
2009-12-22 18:50 ` [Qemu-devel] [PATCH 10/18] net/slirp.c: " Blue Swirl
2009-12-20 9:08 ` [Qemu-devel] Re: [PATCH 09/18] block/qcow2.c: fix warnings " Andreas Schwab
2009-12-20 10:48 ` [Qemu-devel] [PATCH 08/18] block/vvfat.c: " Kevin Wolf
2009-12-22 21:02 ` [Qemu-devel] [PATCH 07/18] block/bochs.c: fix warning " Blue Swirl
2009-12-20 23:02 ` [Qemu-devel] [PATCH 03/18] posix-aio-compat.c: " Paul Brook
2009-12-22 18:35 ` [Qemu-devel] [PATCH 02/18] block.c: " Blue Swirl
2009-12-20 11:38 ` [Qemu-devel] [PATCH 01/18] Do not disable _FORTIFY_SOURCE Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261273167-3240-16-git-send-email-kirill@shutemov.name \
--to=kirill@shutemov.name \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).