qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: qemu-devel@nongnu.org
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>
Subject: [Qemu-devel] [PATCH 04/18] block/cow.c: fix warnings with _FORTIFY_SOURCE
Date: Sun, 20 Dec 2009 03:39:13 +0200	[thread overview]
Message-ID: <1261273167-3240-4-git-send-email-kirill@shutemov.name> (raw)
In-Reply-To: <1261273167-3240-3-git-send-email-kirill@shutemov.name>

  CC    block/cow.o
cc1: warnings being treated as errors
block/cow.c: In function 'cow_create':
block/cow.c:251: error: ignoring return value of 'write', declared with attribute warn_unused_result
block/cow.c:253: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_result
make: *** [block/cow.o] Error 1

Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
---
 block/cow.c |   19 ++++++++++++++++---
 1 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/block/cow.c b/block/cow.c
index a70854e..1132614 100644
--- a/block/cow.c
+++ b/block/cow.c
@@ -209,6 +209,7 @@ static int cow_create(const char *filename, QEMUOptionParameter *options)
     struct stat st;
     int64_t image_sectors = 0;
     const char *image_filename = NULL;
+    int ret;
 
     /* Read out options */
     while (options && options->name) {
@@ -248,11 +249,23 @@ static int cow_create(const char *filename, QEMUOptionParameter *options)
     }
     cow_header.sectorsize = cpu_to_be32(512);
     cow_header.size = cpu_to_be64(image_sectors * 512);
-    write(cow_fd, &cow_header, sizeof(cow_header));
+    ret = write(cow_fd, &cow_header, sizeof(cow_header));
+    if (ret != sizeof(cow_header)) {
+        ret = -errno;
+        goto exit;
+    }
+
     /* resize to include at least all the bitmap */
-    ftruncate(cow_fd, sizeof(cow_header) + ((image_sectors + 7) >> 3));
+    ret = ftruncate(cow_fd, sizeof(cow_header) + ((image_sectors + 7) >> 3));
+    if (ret) {
+        ret = -errno;
+        goto exit;
+    }
+
+    ret = 0;
+exit:
     close(cow_fd);
-    return 0;
+    return ret;
 }
 
 static void cow_flush(BlockDriverState *bs)
-- 
1.6.5.6

  reply	other threads:[~2009-12-20  1:39 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-20  1:39 [Qemu-devel] [PATCH 01/18] Do not disable _FORTIFY_SOURCE Kirill A. Shutemov
2009-12-20  1:39 ` [Qemu-devel] [PATCH 02/18] block.c: fix warning with _FORTIFY_SOURCE Kirill A. Shutemov
2009-12-20  1:39   ` [Qemu-devel] [PATCH 03/18] posix-aio-compat.c: " Kirill A. Shutemov
2009-12-20  1:39     ` Kirill A. Shutemov [this message]
2009-12-20  1:39       ` [Qemu-devel] [PATCH 05/18] block/qcow.c: fix warnings " Kirill A. Shutemov
2009-12-20  1:39         ` [Qemu-devel] [PATCH 06/18] block/vmdk.o: " Kirill A. Shutemov
2009-12-20  1:39           ` [Qemu-devel] [PATCH 07/18] block/bochs.c: fix warning " Kirill A. Shutemov
2009-12-20  1:39             ` [Qemu-devel] [PATCH 08/18] block/vvfat.c: fix warnings " Kirill A. Shutemov
2009-12-20  1:39               ` [Qemu-devel] [PATCH 09/18] block/qcow2.c: " Kirill A. Shutemov
2009-12-20  1:39                 ` [Qemu-devel] [PATCH 10/18] net/slirp.c: fix warning " Kirill A. Shutemov
2009-12-20  1:39                   ` [Qemu-devel] [PATCH 11/18] usb-linux.c: " Kirill A. Shutemov
2009-12-20  1:39                     ` [Qemu-devel] [PATCH 12/18] savevm.c: " Kirill A. Shutemov
2009-12-20  1:39                       ` [Qemu-devel] [PATCH 13/18] slirp/misc.c: " Kirill A. Shutemov
2009-12-20  1:39                         ` [Qemu-devel] [PATCH 14/18] vl.c: " Kirill A. Shutemov
2009-12-20  1:39                           ` [Qemu-devel] [PATCH 15/18] monitor.c: fix warnings " Kirill A. Shutemov
2009-12-20  1:39                             ` [Qemu-devel] [PATCH 16/18] hw/pc.c: " Kirill A. Shutemov
2009-12-20  1:39                               ` [Qemu-devel] [PATCH 17/18] path.c fix warning " Kirill A. Shutemov
2009-12-20  1:39                                 ` [Qemu-devel] [PATCH 18/18] linux-user/mmap.c: fix warnings " Kirill A. Shutemov
2009-12-22 20:49                                 ` [Qemu-devel] [PATCH 17/18] path.c fix warning " Blue Swirl
2009-12-22 20:43                               ` [Qemu-devel] [PATCH 16/18] hw/pc.c: fix warnings " Blue Swirl
2009-12-22 21:12                           ` [Qemu-devel] [PATCH 14/18] vl.c: fix warning " Blue Swirl
2009-12-22 19:21                       ` [Qemu-devel] [PATCH 12/18] savevm.c: " Blue Swirl
2009-12-22 19:03                     ` [Qemu-devel] [PATCH 11/18] usb-linux.c: " Blue Swirl
2009-12-22 18:50                   ` [Qemu-devel] [PATCH 10/18] net/slirp.c: " Blue Swirl
2009-12-20  9:08                 ` [Qemu-devel] Re: [PATCH 09/18] block/qcow2.c: fix warnings " Andreas Schwab
2009-12-20 10:48               ` [Qemu-devel] [PATCH 08/18] block/vvfat.c: " Kevin Wolf
2009-12-22 21:02             ` [Qemu-devel] [PATCH 07/18] block/bochs.c: fix warning " Blue Swirl
2009-12-20 23:02     ` [Qemu-devel] [PATCH 03/18] posix-aio-compat.c: " Paul Brook
2009-12-22 18:35   ` [Qemu-devel] [PATCH 02/18] block.c: " Blue Swirl
2009-12-20 11:38 ` [Qemu-devel] [PATCH 01/18] Do not disable _FORTIFY_SOURCE Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1261273167-3240-4-git-send-email-kirill@shutemov.name \
    --to=kirill@shutemov.name \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).