From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NMnp4-0000m9-Me
	for qemu-devel@nongnu.org; Mon, 21 Dec 2009 14:21:38 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NMnoy-0000g4-1M
	for qemu-devel@nongnu.org; Mon, 21 Dec 2009 14:21:36 -0500
Received: from [199.232.76.173] (port=47852 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NMnox-0000fT-DC
	for qemu-devel@nongnu.org; Mon, 21 Dec 2009 14:21:31 -0500
Received: from smarthost.c4l.co.uk ([82.197.83.77]:36226)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <nathan@parenthephobia.org.uk>)
	id 1NMnox-0007Af-2E
	for qemu-devel@nongnu.org; Mon, 21 Dec 2009 14:21:31 -0500
Subject: Re: [Qemu-devel] [PATCH 3/7] QMP: Assure that returned data is a QDict
From: Nathan Baum <nathan@parenthephobia.org.uk>
In-Reply-To: <1261149905-7622-4-git-send-email-lcapitulino@redhat.com>
References: <1261149905-7622-1-git-send-email-lcapitulino@redhat.com>
	<1261149905-7622-4-git-send-email-lcapitulino@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 21 Dec 2009 19:21:18 +0000
Message-ID: <1261423279.2531.1333.camel@athens>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On Fri, 2009-12-18 at 13:25 -0200, Luiz Capitulino wrote:
> This is for debug purposes only.

This breaks quite a lot of commands where the returned data is a QList,
e.g. query-commands, query-mice, query-cpus. Is the assert wrong, or are
such commands meant to be returning a QDict?

> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  monitor.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/monitor.c b/monitor.c
> index d238660..8ef1582 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -283,6 +283,7 @@ static void monitor_protocol_emitter(Monitor *mon, QObject *data)
>      if (!monitor_has_error(mon)) {
>          /* success response */
>          if (data) {
> +            assert(qobject_type(data) == QTYPE_QDICT);
>              qobject_incref(data);
>              qdict_put_obj(qmp, "return", data);
>          } else {